Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reach into TranscodingSteams internals #119

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

jakobnissen
Copy link
Member

When computing a FASTA index, previously, FASTX used the private state of Buffer from TranscodingStreams. However, in this case, it can just as easily be computed using a local variable.

Closes #118

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.61%. Comparing base (e05e5ce) to head (a0857dd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
+ Coverage   89.78%   92.61%   +2.82%     
==========================================
  Files          15       15              
  Lines         695      704       +9     
==========================================
+ Hits          624      652      +28     
+ Misses         71       52      -19     
Flag Coverage Δ
unittests 92.61% <100.00%> (+2.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

When computing a FASTA index, previously, FASTX used the private state of
Buffer from TranscodingStreams. However, in this case, it can just as easily
be computed using a local variable.
@jakobnissen jakobnissen merged commit b82477a into BioJulia:master Apr 1, 2024
10 checks passed
@jakobnissen jakobnissen deleted the ts_internals branch April 1, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next release of TranscodingStreams will likely break this package
1 participant