Top and bottom chemicals for partition settler #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can help the users specify which chemicals will definitely stay in one of the phases and the rest will go into the other. Useful when composing systems and you won't know everything about the composition of the feed before simulating the complete system. Maybe a process specification can be an alternative to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can help the users specify which chemicals will definitely stay in
one of the phases and the rest will go into the other. Useful when
composing systems and you won't know everything about the composition of
the feed before simulating the complete system.
Maybe a process specification can be an alternative to this.
NOTE: There is a small breaking change in fixing a typo in the argument
partion_idstopartition_ids. If you think breakage is too big for your users, I can revert the change.Clearly describe what the contribution is.
If a new feature is added or existing functionality has changed, the documentation
should also be updated.
Any new or altered functionality should be tested and all tests must pass.
The code coverage should not decrease so that not unnecessary or untested code
is added.