Skip to content

Commit

Permalink
Use List#get(0) instead of getFirst() to support older compilers
Browse files Browse the repository at this point in the history
Signed-off-by: James Duong <[email protected]>
  • Loading branch information
jduo committed Oct 21, 2024
1 parent 9230861 commit d5d0012
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ private List<Map<String, String>> describeTrendlineComputations(
ImmutableMap.of(
"computationType", computation.getComputationType().name().toLowerCase(Locale.ROOT),
"numberOfDataPoints", computation.getNumberOfDataPoints().toString(),
"dataField", computation.getDataField().getChild().getFirst().toString(),
"dataField", computation.getDataField().getChild().get(0).toString(),
"alias", computation.getAlias() != null ? computation.getAlias() : ""))
.collect(Collectors.toList());
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ public class TrendlineOperator extends PhysicalPlan {
@Getter private final List<Trendline.TrendlineComputation> computations;
private final List<TrendlineAccumulator> accumulators;
private final Map<String, Integer> fieldToIndexMap;
private boolean hasAnotherRow = false;

public TrendlineOperator(PhysicalPlan input, List<Trendline.TrendlineComputation> computations) {
this.input = input;
Expand All @@ -41,7 +40,7 @@ public TrendlineOperator(PhysicalPlan input, List<Trendline.TrendlineComputation
fieldToIndexMap = new HashMap<>(computations.size());
for (int i = 0; i < computations.size(); ++i) {

fieldToIndexMap.put(computations.get(i).getDataField().getChild().getFirst().toString(), i);
fieldToIndexMap.put(computations.get(i).getDataField().getChild().get(0).toString(), i);
}
}

Expand Down Expand Up @@ -76,7 +75,7 @@ public ExprValue next() {
if (null != computations.get(i).getAlias()) {
mapBuilder.put(computations.get(i).getAlias(), calculateResult);
} else {
mapBuilder.put(computations.get(i).getDataField().getChild().getFirst().toString(), calculateResult);
mapBuilder.put(computations.get(i).getDataField().getChild().get(0).toString(), calculateResult);
}
}
result = ExprTupleValue.fromExprValueMap(mapBuilder.buildKeepingLast());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ public String visitHead(Head node, String context) {

@Override
public String visitTrendline(Trendline node, String context) {
String child = node.getChild().getFirst().accept(this, context);
String child = node.getChild().get(0).accept(this, context);
String computations = visitExpressionList(node.getComputations());
return StringUtils.format("%s | trendline %s", child, computations);
}
Expand Down

0 comments on commit d5d0012

Please sign in to comment.