Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Build from Upstream Refactor #298

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Conversation

forestmvey
Copy link

Description

Fixes for upstream refactor 8730.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #298 (7f66dd3) into integ-hppc-refactor (8c8e08c) will not change coverage.
The diff coverage is n/a.

@@                  Coverage Diff                   @@
##             integ-hppc-refactor     #298   +/-   ##
======================================================
  Coverage                  97.39%   97.39%           
  Complexity                  4608     4608           
======================================================
  Files                        401      401           
  Lines                      11408    11408           
  Branches                     843      843           
======================================================
  Hits                       11111    11111           
  Misses                       290      290           
  Partials                       7        7           
Flag Coverage Δ
sql-engine 97.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ch/sql/opensearch/client/OpenSearchNodeClient.java 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@forestmvey forestmvey requested a review from a team July 18, 2023 18:53
Copy link

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!
We can ignore BWC failure for now.

@forestmvey forestmvey merged commit 9d78d70 into integ-hppc-refactor Jul 18, 2023
16 of 20 checks passed
@forestmvey forestmvey deleted the dev-hppc-refactor branch July 18, 2023 18:57
forestmvey added a commit that referenced this pull request Jul 18, 2023
matthewryanwells pushed a commit that referenced this pull request Jul 18, 2023
Yury-Fridlyand pushed a commit that referenced this pull request Jul 19, 2023
matthewryanwells pushed a commit that referenced this pull request Jul 19, 2023
MitchellGale pushed a commit that referenced this pull request Jul 20, 2023
MitchellGale pushed a commit that referenced this pull request Jul 20, 2023
MitchellGale pushed a commit that referenced this pull request Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants