Integ/open search exporter setup #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxKsyunz
reviewed
Jul 4, 2023
Comment on lines
23
to
29
| func newTracesExporter(logger *zap.Logger, cfg *Config) (tracesExporter, error) { | ||
| if err := cfg.Validate(); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return newSSOTracesExporter(logger, cfg) | ||
|
|
There was a problem hiding this comment.
You should be able to define a dummy implementation of tracesExporter interface and return it here instead of returning SSOTracesExporter.
That should make it unnecessary to introduce sso_*.go and opensearch_bulk.go files.
Adding config.go content for OpenSearch exporter. Adding new factory.go Adding new sso model OS bulk, readme and adding content to new factory. Removed opensearch_bulk.go, sso_model.go, sso_trace_exporter.go, trace_exporter.go. sorted imports in factor.go.
MitchellGale
force-pushed
the
integ/OpenSearchExporter-setup
branch
from
7c55f9c
to
ee759b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing comments from open-telemetry#23819.