Java: Add Command GeoSearch & GeoSearchStore #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
java/client/src/main/java/glide/api/commands/GeospatialIndicesBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GeospatialIndicesBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GeospatialIndicesBaseCommands.java
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GeospatialIndicesBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GeospatialIndicesBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/geospatial/GeoSearchResultOptions.java
Show resolved
Hide resolved
| * @see <a href="https://redis.io/commands/geosearch/">redis.io</a> | ||
| */ | ||
| @Getter | ||
| public final class GeoSearchShape { |
There was a problem hiding this comment.
Same here - you can make an interface with two classes.
java/client/src/main/java/glide/api/models/commands/geospatial/GeoSearchShape.java
Outdated
Show resolved
Hide resolved
java/integTest/src/test/java/glide/TransactionTestUtilities.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GeospatialIndicesBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GeospatialIndicesBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GeospatialIndicesBaseCommands.java
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GeospatialIndicesBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GeospatialIndicesBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/geospatial/GeoSearchResultOptions.java
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/geospatial/GeoSearchShape.java
Outdated
Show resolved
Hide resolved
java/integTest/src/test/java/glide/TransactionTestUtilities.java
Outdated
Show resolved
Hide resolved
Yury-Fridlyand
approved these changes
Jun 26, 2024
java/client/src/main/java/glide/api/commands/GeospatialIndicesBaseCommands.java
Outdated
Show resolved
Hide resolved
| * result in <code>destination</code>. | ||
| * | ||
| * @since Redis 6.2.0 and above. | ||
| * @apiNote When in cluster mode, <code>source</code> and <code>destination</code> must map to the |
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/geospatial/GeoSearchStoreOptions.java
Show resolved
Hide resolved
java/integTest/src/test/java/glide/TransactionTestUtilities.java
Outdated
Show resolved
Hide resolved
tjzhang-BQ
force-pushed
the
java/dev_tjz_geosearch
branch
from
94553f3
to
1f0dd44
Compare
tjzhang-BQ
force-pushed
the
java/dev_tjz_geosearch
branch
from
7d61123
to
2dbfd2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.