Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code quality #55

Closed
wants to merge 14 commits into from
Closed

Code quality #55

wants to merge 14 commits into from

Commits on Aug 20, 2021

  1. remove commented include

    @slowriot
    slowriot committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    9cc92cd View commit details
    Browse the repository at this point in the history

  2. remove unused debugging includes

    @slowriot
    slowriot committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    0f12085 View commit details
    Browse the repository at this point in the history

  3. use C++17 fallthrough attributes instead of comments, resolve fallthr… 

    …ough warning
    @slowriot
    slowriot committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    e37e6d9 View commit details
    Browse the repository at this point in the history

  4. don't suppress implicit fallthrough warnings

    @slowriot
    slowriot committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    c85e66f View commit details
    Browse the repository at this point in the history

  5. add modern fallthrough attribute, replace old hacky solutions

    @slowriot
    slowriot committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    4306298 View commit details
    Browse the repository at this point in the history

  6. tidy and remove unneeded braces for cases that don't require them

    @slowriot
    slowriot committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    d5c2f17 View commit details
    Browse the repository at this point in the history

  7. add warning for non-virtual destructor in base class, and fix all ins… 

    …tances
    @slowriot
    slowriot committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    6c49fc9 View commit details
    Browse the repository at this point in the history

  8. add extra performance and safety compiler warnings

    @slowriot
    slowriot committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    2db583d View commit details
    Browse the repository at this point in the history

  9. add warning for implicit double promotion

    @slowriot
    slowriot committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    01e20d1 View commit details
    Browse the repository at this point in the history

  10. avoid unnecessary double promotion in calculating time interval, and … 

    …replace C cast with static_cast
    @slowriot
    slowriot committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    5816487 View commit details
    Browse the repository at this point in the history

  11. avoid implicit conversions that may alter a value, or make them expli… 

    …cit where intended
    @slowriot
    slowriot committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    fa952b5 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2021

  1. placeholder warnings for conversion and useless casts

    @slowriot
    slowriot committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    51b15c8 View commit details
    Browse the repository at this point in the history

  2. do not enable DEBUG_LOCKORDER for all debug builds; the code associat… 

    …ed with this flag is broken in any case
    @slowriot
    slowriot committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    7366be3 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. remove unused includes

    @slowriot
    slowriot committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    82f4086 View commit details
    Browse the repository at this point in the history