Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct hash prefixes used in tests and use consistent pubkey, add tests to reject bitcoin addresses #57

Closed
wants to merge 18 commits into from
Closed

Correct hash prefixes used in tests and use consistent pubkey, add tests to reject bitcoin addresses #57

wants to merge 18 commits into from

Commits on Aug 19, 2021

  1. correct python3 comparison operator

    @slowriot
    slowriot committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    3c0c6c4 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2021

  1. enable building tests by default, external signer default to match bi… 

    …tcoin core, and turn off warning silencing for implicit fallthrough
    @slowriot
    slowriot committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    e027dc7 View commit details
    Browse the repository at this point in the history

  2. reinstate valid base58 test data and test methodology from bitcoin core

    @slowriot
    slowriot committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    0f69252 View commit details
    Browse the repository at this point in the history

  3. fix base58 implementation

    @slowriot
    slowriot committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    60bc8a1 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2021

  1. do not enable DEBUG_LOCKORDER for all debug builds; the code associat… 

    …ed with this flag is broken in any case
    @slowriot
    slowriot committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    a0305ee View commit details
    Browse the repository at this point in the history

  2. don't disable implicit-fallthrough warning (this is now dealt with in… 

    … another PR)
    @slowriot
    slowriot committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    9781fd3 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. enable building tests by default

    @slowriot
    slowriot committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    2f0b88f View commit details
    Browse the repository at this point in the history

  2. re-enable asserts for signet chain params at creation, with correct g… 

    …enesis block hash and merkle root hash
    @slowriot
    slowriot committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    4bf285e View commit details
    Browse the repository at this point in the history

  3. remove unused include

    @slowriot
    slowriot committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    9225ec0 View commit details
    Browse the repository at this point in the history

  4. add tests to verify test addresses are valid - this also tests the va… 

    …lidator
    @slowriot
    slowriot committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    95a1703 View commit details
    Browse the repository at this point in the history

  5. fix failing key_tests, set correct prefix (10) for addresses - the pr… 

    …ior test addresses are BTC addresses (prefix 0), and should not be valid
    @slowriot
    slowriot committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    5555e69 View commit details
    Browse the repository at this point in the history

  6. add a test to ensure a BTC address does not count as a valid destination

    @slowriot
    slowriot committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    4d72a07 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'base58_fixes' into genesis_hashes

    @slowriot
    slowriot committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    43306dc View commit details
    Browse the repository at this point in the history

  8. update benchmark decode address to BGL prefix for consistency

    @slowriot
    slowriot committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    f4a744d View commit details
    Browse the repository at this point in the history

  9. update test data sample BTC address to BGL format with prefix 10

    @slowriot
    slowriot committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    2f87ecb View commit details
    Browse the repository at this point in the history

  10. test data - update BTC format addresses to their BGL equivalent with … 

    …prefix 10
    @slowriot
    slowriot committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    28ed84b View commit details
    Browse the repository at this point in the history

  11. some tests use the pubkey of the BTC genesis block - update these to … 

    …use the correct pubkey of the BGL genesis block instead
    @slowriot
    slowriot committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    4024b28 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2021

  1. update values used in util_tests fixes to match janus branch, to reso… 

    …lve future merge conflict
    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    265f53a View commit details
    Browse the repository at this point in the history