Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove useless make dependencies n°1 #3883

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

noraj
Copy link
Contributor

@noraj noraj commented Jun 28, 2023

https://wiki.archlinux.org/index.php/PKGBUILD#makedepends

The dependencies required should be the minimum and so eliminating useless dependencies.

Note: The meta-package base-devel is assumed to be already installed when building with makepkg. Members of this group should not be included in makedepends array.

Tip: The following can be used to check whether a particular package is either in the base-devel group or is pulled in by a member of the group:

LC_ALL=C pacman -Si $(pactree -rl package) 2>/dev/null | grep -q "^Groups *:.*base-devel"

Commands to search for useless deps:

grep -r "^makedepends=(" packages | grep -E "'(autoconf|automake|binutils|bison|fakeroot|file|findutils|flex|gawk|gcc|gettext|grep|groff|gzip|libtool|m4|make|pacman|patch|pkgconf|pkg-config|sed|sudo|texinfo|which)'"

Notes:

  • glibc is already pulled by some members of the base-devel group, maybe other sub-depencies may not be caught by the regexp
  • pkg-config is an alias for pkgconf so other aliases may not be listed on the regexp
  • with the example regexp, when makedepends is splitted on multiple lines, extra line won't be caught

duplicates should be removed too:

The packages in the depends array are implicitly required to build the package, they should not be duplicated here.

@noraj noraj requested a review from noptrix as a code owner June 28, 2023 21:02
epoch=1
groups=('blackarch' 'blackarch-webapp' 'blackarch-fuzzer' 'blackarch-scanner')
pkgdesc='Web security tool to make fuzzing at HTTP inputs, made in C with libCurl.'
arch=('x86_64' 'aarch64')
url='https://github.com/CoolerVoid/0d1n'
license=('GPL3')
depends=('curl')
makedepends=('git' 'make')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

base-devel

groups=('blackarch' 'blackarch-scanner')
pkgdesc='ADM SNMP audit scanner.'
license=('GPL')
depends=('glibc')
makedepends=('gcc')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

base-devel

groups=('blackarch' 'blackarch-forensic')
pkgdesc='An extensible open format for the storage of disk images and related forensic information.'
arch=('any')
url='https://github.com/sshock/AFFLIBv3'
license=('custom:unknown')
depends=('ncurses' 'zlib' 'openssl' 'curl' 'expat' 'readline' 'fuse2')
makedepends=('make' 'gcc' 'ncurses' 'zlib' 'openssl' 'curl' 'expat' 'readline'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

base-devel + duplicates with depends

epoch=1
groups=('blackarch' 'blackarch-networking' 'blackarch-defensive')
pkgdesc='A packet inspection engine with capabilities of learning without any human intervention.'
arch=('x86_64' 'aarch64')
url='https://bitbucket.org/camp0/aiengine/downloads/'
license=('GPL3')
depends=('boost' 'boost-libs' 'python' 'libpcap')
makedepends=('make')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

base-devel

pkgdesc='AntiVirus Evasion Tool'
arch=('any')
groups=('blackarch' 'blackarch-binary' 'blackarch-backdoor' 'blackarch-automation')
url='https://github.com/govolution/avet'
license=('GPL3')
depends=('python' 'wine' 'wine-mono' 'wine_gecko')
makedepends=('git' 'gcc')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

base-devel

@noraj noraj changed the title remove useless make dependencies remove useless make dependencies n°1 Jul 3, 2023
@noraj noraj mentioned this pull request Jul 7, 2023
@D3vil0p3r
Copy link
Contributor

D3vil0p3r commented Sep 30, 2023

One question: can base-devel be used as makedepends? If so or not, why?

@noraj
Copy link
Contributor Author

noraj commented Sep 30, 2023

One question: can base-devel be used as makedepends? If so or not, why?

I think meta groups can be used as dependencies yes. But as explained in the ArchLinux wiki, it's useless to include it.

@noraj noraj mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants