Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lrod: add package #4282

Merged
merged 6 commits into from
Nov 5, 2024
Merged

lrod: add package #4282

merged 6 commits into from
Nov 5, 2024

Conversation

D3vil0p3r
Copy link
Contributor

@D3vil0p3r D3vil0p3r commented Oct 9, 2024 •
edited
Loading

Close #4091

@D3vil0p3r D3vil0p3r marked this pull request as ready for review October 9, 2024 18:44
@D3vil0p3r D3vil0p3r mentioned this pull request Oct 9, 2024
Closed
noraj
noraj requested changes Nov 1, 2024
View reviewed changes
packages/lrod/PKGBUILD Show resolved Hide resolved
packages/lrod/PKGBUILD Show resolved Hide resolved
@D3vil0p3r D3vil0p3r requested a review from noraj November 2, 2024 14:17
noraj
noraj requested changes Nov 2, 2024
View reviewed changes
Copy link
Contributor

@noraj noraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested

  • building
  • runtime

there is an error with post install script

ERROR: file:///usr/share/lrod does not appear to be a Python project: neither 'setup.py' nor 'pyproject.toml' found.
error: command failed to execute correctly

packages/lrod/lrod.install Outdated Show resolved Hide resolved
noraj
noraj requested changes Nov 2, 2024
View reviewed changes
packages/lrod/PKGBUILD Outdated Show resolved Hide resolved
D3vil0p3r and others added 2 commits November 2, 2024 18:59
@D3vil0p3r @noraj
Update packages/lrod/PKGBUILD
c40c662 
Co-authored-by: Alexandre ZANNI <[email protected]>
@D3vil0p3r @noraj
Update packages/lrod/lrod.install
9de8bf8 
Co-authored-by: Alexandre ZANNI <[email protected]>
@D3vil0p3r
Copy link
Contributor Author

Tested by ba-dev. It works now. Thank you for suggestions.

@D3vil0p3r D3vil0p3r requested a review from noraj November 2, 2024 18:08
noraj
noraj approved these changes Nov 2, 2024
View reviewed changes
Copy link
Contributor

@noraj noraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noptrix noptrix merged commit 848d8ff into BlackArch:master Nov 5, 2024
2 checks passed
@D3vil0p3r D3vil0p3r deleted the patch-42 branch November 5, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noraj noraj noraj approved these changes

@noptrix noptrix Awaiting requested review from noptrix noptrix is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implementation of a tool
3 participants
@D3vil0p3r @noraj @noptrix