Handle reading null JSON values when creating CDATA elements (#111)

README.md

@@ -68,7 +68,7 @@ The built binary will be available as `./bin/oq`.  This can be relocated elsewhe
 
 ```dockerfile
 # Set an arg to store the oq version that should be installed.
-ARG OQ_VERSION=1.3.3
+ARG OQ_VERSION=1.3.4
 
 # Grab the binary from the latest Github release and make it executable; placing it within /usr/local/bin.  Can also put it elsewhere if you so desire.
 RUN wget https://github.com/Blacksmoke16/oq/releases/download/v${OQ_VERSION}/oq-v${OQ_VERSION}-linux-x86_64 -O /usr/local/bin/oq && chmod +x /usr/local/bin/oq

shard.yml

@@ -3,7 +3,7 @@ name: oq
 description: |
   A performant, and portable jq wrapper thats facilitates the consumption and output of formats other than JSON; using jq filters to transform the data.
 
-version: 1.3.3
+version: 1.3.4
 
 authors:
   - George Dietrich <[email protected]>

snap/snapcraft.yaml

@@ -1,5 +1,5 @@
 name: oq
-version: '1.3.3'
+version: '1.3.4'
 summary: A performant, and portable jq wrapper to support formats other than JSON
 description: |
   A performant, and portable jq wrapper thats facilitates the consumption and output of formats other than JSON; using jq filters to transform the data.

spec/converters/xml_spec.cr

@@ -703,6 +703,18 @@ describe OQ::Converters::XML do
             )
           end
         end
+
+        it "should produce an empty CDATA if the json key starts with '!' and the value is null" do
+          run_binary(%({"!x":null}), args: ["-o", "xml", "."]) do |output|
+            output.should eq(<<-XML
+              <?xml version="1.0" encoding="UTF-8"?>
+              <root>
+                <x><![CDATA[]]></x>
+              </root>\n
+              XML
+            )
+          end
+        end
       end
     end
 

src/converters/xml.cr

@@ -196,6 +196,7 @@ module OQ::Converters::XML
     when .int?    then json.read_int
     when .float?  then json.read_float
     when .bool?   then json.read_bool
+    when .null?   then json.read_null
     else
       ""
     end.to_s

src/oq.cr

@@ -6,7 +6,7 @@ require "./converters/*"
 
 # A performant, and portable jq wrapper thats facilitates the consumption and output of formats other than JSON; using jq filters to transform the data.
 module OQ
-  VERSION = "1.3.3"
+  VERSION = "1.3.4"
 
   # The support formats that can be converted to/from.
   enum Format