Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle EOF input from jq #83

Merged
merged 4 commits into from
Aug 1, 2021
Merged

Handle EOF input from jq #83

merged 4 commits into from
Aug 1, 2021

Conversation

Blacksmoke16
Copy link
Owner

@Blacksmoke16 Blacksmoke16 commented Jul 1, 2021 •
edited
Loading

  • Ensure spec processes exit successfully unless otherwise specified

Fixes #82

Depends on crystal-lang/crystal#10864

@Blacksmoke16
Handle EOF input from jq
258b877 
Ensure process is successful unless otherwise specified
@Blacksmoke16
Use the expectation
4f6372a
@Blacksmoke16 Blacksmoke16 added kind:bug An existing feature isn't doing something correctly format:yaml labels Jul 1, 2021
@Blacksmoke16 Blacksmoke16 mentioned this pull request Jul 1, 2021
Closed
@Blacksmoke16
Manually handle the EOF exception
69d2450 
Can be removed after next Crystal release
@Blacksmoke16 Blacksmoke16 marked this pull request as ready for review August 1, 2021 20:05
@Blacksmoke16 Blacksmoke16 merged commit 0d92239 into master Aug 1, 2021
@Blacksmoke16 Blacksmoke16 deleted the handle-eof-io branch August 1, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
format:yaml kind:bug An existing feature isn't doing something correctly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unusual behaviour with empty YAML documents
1 participant
@Blacksmoke16