Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Version of Jmeter to 5.6.2 #1776

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kamyarz-aws
Copy link

@kamyarz-aws kamyarz-aws commented Oct 13, 2023

Each PR must conform to Developer's Guide.

Updating JMETER Version to 5.6.2.

Quick checklist:

  • Description of PR explains the context of change
  • Unit tests cover the change, no broken tests
  • No static analysis warnings (Codacy etc.)
  • Documentation update ('available in the unstable snapshot' warning if necessary)
  • Changes file inside site/dat/docs/changes directory, one-line note of change inside

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #1776 (167bbcf) into master (6abe1a1) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1776      +/-   ##
==========================================
+ Coverage   89.06%   89.11%   +0.05%     
==========================================
  Files          70       70              
  Lines       18996    18978      -18     
==========================================
- Hits        16917    16910       -7     
+ Misses       2079     2068      -11     
Files Coverage Δ
bzt/modules/jmeter.py 86.44% <100.00%> (+0.74%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -1611,22 +1611,6 @@ def _get_jar_fixes(self, lib_dir):

return direct_install_tools

def _fix_jquery_in_jmeter(self, jmeter_dir):
if not self.fix_jars or LooseVersion(self.version) < LooseVersion('5.0.0'):
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted this function since LooseVersion is never less than 5 so it could be deleted

@kamyarz-aws kamyarz-aws changed the title Updating Version of Jmeter Pending Pipeline Updating Version of Jmeter Oct 16, 2023
@kamyarz-aws
Copy link
Author

@mykhaliev1 I am unable to add reviewers to this. I made these changes. All the pipelines are passing. I did the docker build and ran a couple tests on top of it and it works.

@kamyarz-aws kamyarz-aws changed the title Updating Version of Jmeter Updating Version of Jmeter to 5.6.2 Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant