[WIP] feature/table-from-postgresl-sqlite #1453
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
…ahuasi/blazingsql into feature/table-from-postgresl-sqlite
…o avoid overlapping
…le-from-postgresl-sqlite
aucahuasi
approved these changes
Apr 22, 2021
…/blazingsql into feature/table-from-postgresl-sqlite
wmalpica
approved these changes
Apr 30, 2021
| }; | ||
|
|
||
| TableInfo ExecuteTableInfo(PGconn *connection, const sql_info &sql) { | ||
| PGresult *result = PQexec(connection, MakeQueryForColumnsInfo(sql).c_str()); | ||
| inline TableInfo ExecuteTableInfo(PGconn * connection, const sql_info & sql) { |
There was a problem hiding this comment.
@williamBlazing, all SQL-providers have a function to get a list columns of the table used to load the data.
So, a TableInfo contains the list of columns and their data types (to be parsed)
felipeblazing
approved these changes
May 4, 2021
|
run tests |
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
|
run tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #1443