-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): replace list of TransactionCard
by new PaginatedTable
on the transactions view
#458
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
📦 Next.js Bundle Analysis for @blobscan/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Two Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job.
Left a few comments with some details we need to address.
apps/web/src/components/PaginatedTable/helpers/transactions.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/components/PaginatedTable/helpers/transactions.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/components/PaginatedTable/helpers/transactions.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/components/PaginatedTable/helpers/transactions.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/components/PaginatedTable/helpers/transactions.tsx
Outdated
Show resolved
Hide resolved
3ceec36
to
1e44c7a
Compare
36eefac
to
ce4341f
Compare
🦋 Changeset detectedLatest commit: da0b4a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ce4341f
to
4299155
Compare
4299155
to
7dfd92d
Compare
7dfd92d
to
6e04662
Compare
d7e5c1f
to
c61df55
Compare
6e04662
to
8c22399
Compare
3b0e644
to
b199b62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments I forgot to add in the first review
8c22399
to
309e83d
Compare
b199b62
to
fd1d47d
Compare
a35e13b
to
554b208
Compare
554b208
to
38c4ad8
Compare
fd1d47d
to
caf6a77
Compare
38c4ad8
to
ae071de
Compare
caf6a77
to
452103f
Compare
ae071de
to
565e912
Compare
565e912
to
da0b4a7
Compare
Checklist
Description
It resolves #451
Migrate the current 'transaction view' using a transaction card list to the new
PaginatedTable
componentScreenshots