Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): replace list of TransactionCard by new PaginatedTable on the transactions view #458

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

xFJA
Copy link
Collaborator

@xFJA xFJA commented Jul 29, 2024

Checklist

  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

It resolves #451

Migrate the current 'transaction view' using a transaction card list to the new PaginatedTable component

Screenshots

image

@xFJA xFJA requested a review from PJColombo July 29, 2024 17:43
Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blobscan-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2024 1:00pm
blobscan-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2024 1:00pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
blobscan-gnosis ⬜️ Ignored (Inspect) Visit Preview Aug 1, 2024 1:00pm
blobscan-holesky ⬜️ Ignored (Inspect) Visit Preview Aug 1, 2024 1:00pm
blobscan-mainnet ⬜️ Ignored (Inspect) Visit Preview Aug 1, 2024 1:00pm
blobscan-sepolia ⬜️ Ignored (Inspect) Visit Preview Aug 1, 2024 1:00pm

Copy link
Contributor

github-actions bot commented Jul 29, 2024

📦 Next.js Bundle Analysis for @blobscan/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/blob/[hash] 42.43 KB 286.9 KB 81.97% (🟢 -0.18%)
/blocks 30.68 KB 275.15 KB 78.61% (🟡 +3.40%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link
Member

@PJColombo PJColombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job.

Left a few comments with some details we need to address.

@xFJA xFJA force-pushed the migrate-blocks-card-view-to-table branch 2 times, most recently from 3ceec36 to 1e44c7a Compare July 30, 2024 22:51
@xFJA xFJA force-pushed the migrate-transactions-card-view-to-table branch from 36eefac to ce4341f Compare July 30, 2024 23:35
Copy link

changeset-bot bot commented Jul 30, 2024

🦋 Changeset detected

Latest commit: da0b4a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@blobscan/web Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@xFJA xFJA force-pushed the migrate-blocks-card-view-to-table branch from 3b0e644 to b199b62 Compare August 1, 2024 10:28
Copy link
Member

@PJColombo PJColombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments I forgot to add in the first review

@xFJA xFJA force-pushed the migrate-blocks-card-view-to-table branch from b199b62 to fd1d47d Compare August 1, 2024 11:51
@xFJA xFJA force-pushed the migrate-transactions-card-view-to-table branch 2 times, most recently from a35e13b to 554b208 Compare August 1, 2024 11:56
@PJColombo PJColombo force-pushed the migrate-transactions-card-view-to-table branch from 554b208 to 38c4ad8 Compare August 1, 2024 12:02
@xFJA xFJA force-pushed the migrate-blocks-card-view-to-table branch from fd1d47d to caf6a77 Compare August 1, 2024 12:14
@xFJA xFJA force-pushed the migrate-transactions-card-view-to-table branch from 38c4ad8 to ae071de Compare August 1, 2024 12:15
@xFJA xFJA force-pushed the migrate-blocks-card-view-to-table branch from caf6a77 to 452103f Compare August 1, 2024 12:22
@xFJA xFJA force-pushed the migrate-transactions-card-view-to-table branch from ae071de to 565e912 Compare August 1, 2024 12:24
@xFJA xFJA force-pushed the migrate-transactions-card-view-to-table branch from 565e912 to da0b4a7 Compare August 1, 2024 12:52
@xFJA xFJA changed the base branch from migrate-blocks-card-view-to-table to next August 1, 2024 12:52
@xFJA xFJA merged commit ff075a9 into next Aug 1, 2024
7 checks passed
@PJColombo PJColombo deleted the migrate-transactions-card-view-to-table branch August 1, 2024 13:03
@github-actions github-actions bot mentioned this pull request Aug 2, 2024
@github-actions github-actions bot mentioned this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use table instead of cards in transactions pages
2 participants