Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add LatestGasPrice component #470

Merged
merged 4 commits into from
Aug 2, 2024
Merged

feat: add LatestGasPrice component #470

merged 4 commits into from
Aug 2, 2024

Conversation

luis-herasme
Copy link
Member

Checklist

  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

Add the LatestGasPrice component to the ExplorerDetails component to display the latest gas price. This component fetches the latest gas price data from the API and renders it in the UI.

Related Issue

Closes #421

Screenshots:

image

Copy link

changeset-bot bot commented Aug 1, 2024

🦋 Changeset detected

Latest commit: 821a565

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@blobscan/api Minor
@blobscan/web Minor
@blobscan/rest-api-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Aug 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
blobscan-docs ⬜️ Ignored (Inspect) Visit Preview Aug 2, 2024 2:28pm
blobscan-gnosis ⬜️ Ignored (Inspect) Visit Preview Aug 2, 2024 2:28pm
blobscan-holesky ⬜️ Ignored (Inspect) Visit Preview Aug 2, 2024 2:28pm
blobscan-mainnet ⬜️ Ignored (Inspect) Visit Preview Aug 2, 2024 2:28pm
blobscan-sepolia ⬜️ Ignored (Inspect) Visit Preview Aug 2, 2024 2:28pm
blobscan-staging ⬜️ Ignored (Inspect) Visit Preview Aug 2, 2024 2:28pm

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.84%. Comparing base (deb72ed) to head (821a565).
Report is 8 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #470   +/-   ##
=======================================
  Coverage   89.84%   89.84%           
=======================================
  Files         146      145    -1     
  Lines        9621     9622    +1     
  Branches     1019     1020    +1     
=======================================
+ Hits         8644     8645    +1     
  Misses        977      977           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Aug 1, 2024

📦 Next.js Bundle Analysis for @blobscan/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 245.66 KB (🟡 +743 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link
Member

@PJColombo PJColombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

I’ve left some comments requesting a few refactoring changes.

apps/web/src/components/GasPrice.tsx Outdated Show resolved Hide resolved
apps/web/src/components/ExplorerDetails.tsx Outdated Show resolved Hide resolved
packages/api/src/routers/block/getGasPrice.ts Outdated Show resolved Hide resolved
Copy link
Member

@PJColombo PJColombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a couple of last comments I forgot to include in the first revision

Feel free to squash/merge this once they get resolved

Also, don't forget to add the changeset

apps/web/src/components/ExplorerDetails.tsx Outdated Show resolved Hide resolved
apps/web/src/components/ExplorerDetails.tsx Outdated Show resolved Hide resolved
@luis-herasme luis-herasme merged commit 4bc7884 into next Aug 2, 2024
14 checks passed
This was referenced Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display current blob gas price
2 participants