Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy to clipboard #478

Merged
merged 19 commits into from
Aug 12, 2024
Merged

Copy to clipboard #478

merged 19 commits into from
Aug 12, 2024

Conversation

luis-herasme
Copy link
Member

Checklist

  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

Adds CopyToClipboard component

Motivation and Context (Optional)

Related Issue

Closes #475

Screenshots:

image
image
image
image
image
image

Copy link

vercel bot commented Aug 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blobscan-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 3:14pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
blobscan-docs ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 3:14pm
blobscan-gnosis ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 3:14pm
blobscan-holesky ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 3:14pm
blobscan-mainnet ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 3:14pm
blobscan-sepolia ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 3:14pm

Copy link

changeset-bot bot commented Aug 3, 2024

🦋 Changeset detected

Latest commit: 510c8b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@blobscan/web Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 3, 2024

📦 Next.js Bundle Analysis for @blobscan/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/blob/[hash] 43.13 KB 288.91 KB 82.55% (🟡 +0.19%)
/block/[id] 29.77 KB 275.56 KB 78.73% (🟡 +0.26%)
/tx/[hash] 14.01 KB 259.8 KB 74.23% (🟡 +0.22%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link

codecov bot commented Aug 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@4bc7884). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #478   +/-   ##
=======================================
  Coverage        ?   89.83%           
=======================================
  Files           ?      146           
  Lines           ?     9630           
  Branches        ?     1020           
=======================================
  Hits            ?     8651           
  Misses          ?      979           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@PJColombo PJColombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job

Left a few comments

apps/web/src/components/CopyToClipboard.tsx Outdated Show resolved Hide resolved
apps/web/src/components/CopyToClipboard.tsx Outdated Show resolved Hide resolved
apps/web/src/components/CopyToClipboard.tsx Show resolved Hide resolved
apps/web/src/pages/blob/[hash].tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@xFJA xFJA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 💪

Copy link
Member

@PJColombo PJColombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

left a couple of last comments

Once resolved I believe we can merge this 👍

apps/web/src/components/CopyToClipboard.tsx Outdated Show resolved Hide resolved
apps/web/src/pages/blob/[hash].tsx Outdated Show resolved Hide resolved
@luis-herasme luis-herasme merged commit 85afe5b into main Aug 12, 2024
14 checks passed
@github-actions github-actions bot mentioned this pull request Aug 12, 2024
@PabloCastellano PabloCastellano deleted the copy-to-clipboard branch August 13, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a "copy to clipboard" icon button next to hashes
3 participants