Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block stats #515

Merged
merged 6 commits into from
Aug 27, 2024
Merged

Fix block stats #515

merged 6 commits into from
Aug 27, 2024

Conversation

luis-herasme
Copy link
Member

No description provided.

Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
blobscan-docs ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 2:38pm
blobscan-gnosis ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 2:38pm
blobscan-holesky ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 2:38pm
blobscan-mainnet ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 2:38pm
blobscan-sepolia ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 2:38pm
blobscan-staging ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 2:38pm

Copy link

changeset-bot bot commented Aug 21, 2024

🦋 Changeset detected

Latest commit: be66231

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@blobscan/web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 21, 2024

📦 Next.js Bundle Analysis for @blobscan/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 271.14 KB (🟡 +25.52 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eleven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/ 352.27 KB 623.41 KB 178.12% (🟢 -4.88%)
/address/[address] 26.71 KB 297.84 KB 85.10% (🟢 -4.87%)
/blob/[hash] 26.08 KB 297.21 KB 84.92% (🟢 -4.67%)
/blobs 15.82 KB 286.96 KB 81.99% (🟢 -4.86%)
/block/[id] 12.6 KB 283.74 KB 81.07% (🟢 -4.65%)
/blocks 13.55 KB 284.69 KB 81.34% (🟢 -4.86%)
/stats/blob 336.48 KB 607.62 KB 173.61% (🟢 -4.80%)
/stats/block 337.51 KB 608.65 KB 173.90% (🟢 -4.80%)
/stats/tx 336.61 KB 607.75 KB 173.64% (🟢 -4.79%)
/tx/[hash] 14.04 KB 285.17 KB 81.48% (🟡 +0.22%)
/txs 20.09 KB 291.23 KB 83.21% (🟢 -4.86%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link
Member

@PabloCastellano PabloCastellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@PJColombo PJColombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We’re currently rounding the metrics instead of displaying the actual values.

To address this, I suggest updating the convertWei function to handle decimal values as it was doing before. As shown by the errors, there are cases where we encounter wei values with decimals, particularly when dealing with averages.

Additionally, I noticed that we’re always converting values to big integers before passing them to convertWei. Instead of doing this, we could let the function itself handle the normalization of input parameters, as it was done prior to the changes in PR #493.

Copy link
Member

@PJColombo PJColombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@PabloCastellano PabloCastellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@luis-herasme luis-herasme merged commit b23e7d7 into main Aug 27, 2024
8 checks passed
@PJColombo PJColombo deleted the fix-block-stats branch August 28, 2024 00:08
@github-actions github-actions bot mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants