Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Sort input in Filters #543

Merged
merged 5 commits into from
Sep 5, 2024
Merged

feat: add Sort input in Filters #543

merged 5 commits into from
Sep 5, 2024

Conversation

xFJA
Copy link
Collaborator

@xFJA xFJA commented Sep 4, 2024

Checklist

  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

  • Created IconButtonGroup component to be able to have a toggle between icons for the sorting types
  • Added a sorting input in the Filters component to choose to list the items in blocks, blobs and transactions table views in ascending or descending order

Related Issue

Closes #435

Screenshots

image

Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blobscan-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 10:21am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
blobscan-docs ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 10:21am
blobscan-gnosis ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 10:21am
blobscan-holesky ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 10:21am
blobscan-mainnet ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 10:21am
blobscan-sepolia ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 10:21am

Copy link

changeset-bot bot commented Sep 4, 2024

🦋 Changeset detected

Latest commit: 0ec6402

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@blobscan/web Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 4, 2024

📦 Next.js Bundle Analysis for @blobscan/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 283.66 KB (🟡 +38.04 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/block_neighbor 251 B 283.9 KB 81.11%

Eleven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/ 352.46 KB 636.12 KB 181.75% (🟢 -4.82%)
/address/[address] 27.29 KB 310.95 KB 88.84% (🟢 -4.69%)
/blob/[hash] 27.33 KB 310.98 KB 88.85% (🟢 -4.31%)
/blobs 75.95 KB 359.61 KB 102.74% (🟡 +12.32%)
/block/[id] 14.01 KB 297.67 KB 85.05% (🟢 -4.25%)
/blocks 73.66 KB 357.32 KB 102.09% (🟡 +12.32%)
/stats/blob 336.49 KB 620.15 KB 177.18% (🟢 -4.79%)
/stats/block 337.64 KB 621.29 KB 177.51% (🟢 -4.76%)
/stats/tx 336.75 KB 620.41 KB 177.26% (🟢 -4.76%)
/tx/[hash] 15.07 KB 298.72 KB 85.35% (🟡 +0.52%)
/txs 73.14 KB 356.8 KB 101.94% (🟡 +10.30%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link
Member

@PJColombo PJColombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can simplify the design by doing something similar to the ThemeModeButton: using a single icon wrapped in an IconButton that toggles between BarsArrowDownIcon and BarsArrowUpIcon when clicked.

I would also have the desc sort set as default

@PJColombo
Copy link
Member

Can we also add a changeset?

Copy link
Member

@PabloCastellano PabloCastellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xFJA
Copy link
Collaborator Author

xFJA commented Sep 5, 2024

I think we can simplify the design by doing something similar to the ThemeModeButton: using a single icon wrapped in an IconButton that toggles between BarsArrowDownIcon and BarsArrowUpIcon when clicked.

I would also have the desc sort set as default

Done! It seems more simple and clear now 👍

@xFJA
Copy link
Collaborator Author

xFJA commented Sep 5, 2024

Can we also add a changeset?

The changeset script wasn't working. After fixing the config file (updating the base branch to main), the issue has been solved. This could be related with the recent pnpm update

Copy link
Member

@PJColombo PJColombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xFJA xFJA merged commit 958c234 into main Sep 5, 2024
11 of 12 checks passed
@xFJA xFJA deleted the create-sort-filters branch September 19, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to sort elements in ascending or descending order in blobs, blocks and transactions pages
4 participants