Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add category field #551

Merged
merged 8 commits into from
Sep 5, 2024
Merged

feat: add category field #551

merged 8 commits into from
Sep 5, 2024

Conversation

PJColombo
Copy link
Member

@PJColombo PJColombo commented Sep 5, 2024

Checklist

  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

This update adds a category column to the Transaction model, which can hold values such as "OTHER" or "ROLLUP". The new field is also exposed via the API

Motivation and Context (Optional)

Introducing a general type field in the transaction model will enable us to identify various types of blobs that are not exclusively related to rollups (e.g., blobscriptions). This enhancement will also simplify the filtering process, allowing for more efficient queries across both rollups and other blob types.

Related Issue (Optional)

Screenshots (if appropriate):

Copy link

changeset-bot bot commented Sep 5, 2024

🦋 Changeset detected

Latest commit: f772360

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@blobscan/api Minor
@blobscan/db Minor
@blobscan/rest-api-server Patch
@blobscan/web Patch
@blobscan/blob-propagation-jobs-cli Patch
@blobscan/stats-aggregation-cli Patch
@blobscan/auth Patch
@blobscan/blob-propagator Patch
@blobscan/blob-storage-manager Patch
@blobscan/rollups Patch
@blobscan/syncers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blobscan-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 1:33pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
blobscan-docs ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 1:33pm
blobscan-gnosis ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 1:33pm
blobscan-holesky ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 1:33pm
blobscan-mainnet ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 1:33pm
blobscan-sepolia ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 1:33pm

@PJColombo PJColombo changed the title Feat/add blob categories feat: add category field Sep 5, 2024
Copy link
Contributor

github-actions bot commented Sep 5, 2024

📦 Next.js Bundle Analysis for @blobscan/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 283.66 KB (🟡 +38.04 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/block_neighbor 251 B 283.9 KB 81.12%

Eleven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/ 352.46 KB 636.12 KB 181.75% (🟢 -4.82%)
/address/[address] 27.29 KB 310.95 KB 88.84% (🟢 -4.69%)
/blob/[hash] 27.33 KB 310.98 KB 88.85% (🟢 -4.31%)
/blobs 75.95 KB 359.61 KB 102.75% (🟡 +12.32%)
/block/[id] 14.01 KB 297.67 KB 85.05% (🟢 -4.25%)
/blocks 73.67 KB 357.33 KB 102.09% (🟡 +12.32%)
/stats/blob 336.49 KB 620.15 KB 177.19% (🟢 -4.80%)
/stats/block 337.64 KB 621.29 KB 177.51% (🟢 -4.76%)
/stats/tx 336.75 KB 620.41 KB 177.26% (🟢 -4.76%)
/tx/[hash] 15.07 KB 298.73 KB 85.35% (🟡 +0.52%)
/txs 73.15 KB 356.81 KB 101.94% (🟡 +10.30%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link
Member

@PabloCastellano PabloCastellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like adding the field to blobs_on_transactions was a mistake and then you removed it, right?

In this case better edit the first migration and remove second one. But I guess it doesn't hurt.

RETURNING transaction.hash
)
-- Count the number of updated rows in this batch
SELECT count(1) INTO update_count FROM update_rows;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the migration script. But what does this line? Does it print the result to stdout?

Copy link
Member Author

@PJColombo PJColombo Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It stores the number of previously updated rows in update_count

count(1) is the same than using count(*)

@PJColombo PJColombo merged commit 7240bba into main Sep 5, 2024
11 of 12 checks passed
@PJColombo PJColombo deleted the feat/add-blob-categories branch September 5, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants