Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix show more #568

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Fix show more #568

merged 2 commits into from
Sep 16, 2024

Conversation

luis-herasme
Copy link
Member

Checklist

  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

Fixed the issue where the "Show more" message was displayed incorrectly when the blob data container was opened and closed. The message now properly toggles between "Show more" when the container is closed and "Show less" when the container is open.

Related Issue

Closes #565

Screenshots:

Before:
image
image

Copy link

changeset-bot bot commented Sep 12, 2024

🦋 Changeset detected

Latest commit: 096fb81

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@blobscan/web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blobscan-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 8:29pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
blobscan-docs ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 8:29pm
blobscan-gnosis ⬜️ Ignored (Inspect) Sep 12, 2024 8:29pm
blobscan-holesky ⬜️ Ignored (Inspect) Sep 12, 2024 8:29pm
blobscan-mainnet ⬜️ Ignored (Inspect) Sep 12, 2024 8:29pm
blobscan-sepolia ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 8:29pm

Copy link
Contributor

📦 Next.js Bundle Analysis for @blobscan/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 283.64 KB (🟡 +38.02 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Pages Added

The following pages were added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/block_neighbor 251 B 283.88 KB 81.11%
/stats 347.49 KB 631.13 KB 180.32%

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/ 352.28 KB 635.92 KB 181.69% (🟢 -4.87%)
/address/[address] 27.29 KB 310.93 KB 88.84% (🟢 -4.70%)
/blob/[hash] 27.36 KB 310.99 KB 88.86% (🟢 -4.31%)
/blobs 75.95 KB 359.59 KB 102.74% (🟡 +12.32%)
/block/[id] 14.13 KB 297.77 KB 85.08% (🟢 -4.21%)
/blocks 73.67 KB 357.31 KB 102.09% (🟡 +12.31%)
/tx/[hash] 15.53 KB 299.17 KB 85.48% (🟡 +0.65%)
/txs 73.15 KB 356.78 KB 101.94% (🟡 +10.30%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.38%. Comparing base (3507a88) to head (096fb81).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #568   +/-   ##
=======================================
  Coverage   89.38%   89.38%           
=======================================
  Files         150      150           
  Lines        9933     9933           
  Branches     1035     1035           
=======================================
  Hits         8879     8879           
  Misses       1054     1054           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PabloCastellano PabloCastellano merged commit cd6176b into main Sep 16, 2024
14 checks passed
@PabloCastellano PabloCastellano deleted the fix-show-more branch September 16, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants