refactor: Simplify SurfaceCardBase component #579
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
=======================================
Coverage 89.37% 89.37%
=======================================
Files 150 150
Lines 9916 9916
Branches 1029 1029
=======================================
Hits 8862 8862
Misses 1054 1054 ☔ View full report in Codecov by Sentry. |
📦 Next.js Bundle Analysis for @blobscan/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
283.79 KB (🟡 +38.17 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
New Pages Added
The following pages were added to the bundle from the code in this PR:
| Page | Size (compressed) | First Load | % of Budget (350 KB) |
|---|---|---|---|
/block_neighbor |
251 B |
284.04 KB | 81.15% |
/stats |
347.54 KB |
631.33 KB | 180.38% |
Eight Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load | % of Budget (350 KB) |
|---|---|---|---|
/ |
351.82 KB |
635.61 KB | 181.60% (🟢 -5.00%) |
/address/[address] |
26.88 KB |
310.67 KB | 88.76% (🟢 -4.81%) |
/blob/[hash] |
27.63 KB |
311.42 KB | 88.98% (🟢 -4.23%) |
/blobs |
76.32 KB |
360.11 KB | 102.89% (🟡 +12.43%) |
/block/[id] |
14.3 KB |
298.09 KB | 85.17% (🟢 -4.16%) |
/blocks |
74.02 KB |
357.81 KB | 102.23% (🟡 +12.42%) |
/tx/[hash] |
16.3 KB |
300.1 KB | 85.74% (🟡 +0.87%) |
/txs |
73.5 KB |
357.3 KB | 102.08% (🟡 +10.41%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.
Checklist
Description
This update refactors the
SurfaceCardBasecomponent to improve its flexibility and simplify style overrides:twMerge: TheSurfaceCardBasecomponent now leveragestwMergeto allow easy style overrides. By usingtwMerge, custom styles passed viaclassNamewill correctly override default styles.truncateText: ThetruncateTextprop has been removed, as it is not used anywhere in the codebase. With the introduction oftwMerge, text truncation and other styles can now be customized or overridden by passing aclassName.This change maintains the same component behavior while enhancing the ability to customize styles.