Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): add a "reorg" label to reorged slots/blocks search results #582

Merged
merged 7 commits into from
Oct 28, 2024

Conversation

luis-herasme
Copy link
Member

Checklist

  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

Adds a reorg label to reorged slots/blocks search results

Related Issue

Closes #406

Screenshots

Before:
image

After:
image
image

Copy link

changeset-bot bot commented Sep 23, 2024

🦋 Changeset detected

Latest commit: 50a6de5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@blobscan/web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blobscan-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 10:08pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
blobscan-docs ⬜️ Ignored (Inspect) Visit Preview Oct 28, 2024 10:08pm
blobscan-gnosis ⬜️ Ignored (Inspect) Visit Preview Oct 28, 2024 10:08pm
blobscan-holesky ⬜️ Ignored (Inspect) Visit Preview Oct 28, 2024 10:08pm
blobscan-mainnet ⬜️ Ignored (Inspect) Visit Preview Oct 28, 2024 10:08pm
blobscan-sepolia ⬜️ Ignored (Inspect) Visit Preview Oct 28, 2024 10:08pm

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.37%. Comparing base (e6d78aa) to head (4da7370).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #582   +/-   ##
=======================================
  Coverage   89.37%   89.37%           
=======================================
  Files         150      150           
  Lines        9916     9916           
  Branches     1029     1029           
=======================================
  Hits         8862     8862           
  Misses       1054     1054           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 23, 2024

📦 Next.js Bundle Analysis for @blobscan/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 332.82 KB (🔴 +87.2 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Pages Added

The following pages were added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/block_neighbor 251 B 333.07 KB 95.16%
/stats 347.54 KB 680.36 KB 194.39%

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/ 351.65 KB 684.47 KB 195.56% (🟢 -5.05%)
/address/[address] 26.8 KB 359.62 KB 102.75% (🟢 -4.84%)
/blob/[hash] 27.5 KB 360.32 KB 102.95% (🟢 -4.27%)
/blobs 76.74 KB 409.57 KB 117.02% (🟡 +12.55%)
/block/[id] 14.17 KB 346.99 KB 99.14% (🟢 -4.20%)
/blocks 74.44 KB 407.27 KB 116.36% (🟡 +12.54%)
/tx/[hash] 16.61 KB 349.43 KB 99.84% (🟡 +0.96%)
/txs 73.94 KB 406.77 KB 116.22% (🟡 +10.53%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link
Member

@PJColombo PJColombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

Left a few comments

apps/web/src/components/Badges/Badge.tsx Outdated Show resolved Hide resolved
.changeset/strong-masks-remain.md Outdated Show resolved Hide resolved
apps/web/src/components/SearchInput/SearchResults.tsx Outdated Show resolved Hide resolved
Copy link
Member

@PJColombo PJColombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type-check and test jobs failed. Can we take a look at those?

Copy link
Member

@PJColombo PJColombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve pushed a commit to fix some search unit tests. All jobs are now passing, so feel free to merge it.

@luis-herasme luis-herasme merged commit 7f55095 into main Oct 28, 2024
12 checks passed
@PJColombo PJColombo deleted the reorg-label branch October 28, 2024 22:12
@github-actions github-actions bot mentioned this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(web): add a "reorg" label to reorged slots/blocks search results
3 participants