fix(web): add chart fixes #598
Conversation
Resolved an issue where the increment animation was being triggered n times, where n is the value of the metric
…e axis + show full (non-compacted) amounts in tooltips + align chart's grid positioning
🦋 Changeset detectedLatest commit: 78bc1e0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
📦 Next.js Bundle Analysis for @blobscan/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
332.95 KB (🔴 +87.33 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
New Pages Added
The following pages were added to the bundle from the code in this PR:
| Page | Size (compressed) | First Load | % of Budget (350 KB) |
|---|---|---|---|
/block_neighbor |
251 B |
333.2 KB | 95.20% |
/stats |
348 KB |
680.96 KB | 194.56% |
Eight Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load | % of Budget (350 KB) |
|---|---|---|---|
/ |
353.07 KB |
686.02 KB | 196.01% (🟢 -4.65%) |
/address/[address] |
28.54 KB |
361.49 KB | 103.28% (🟢 -4.34%) |
/blob/[hash] |
29.22 KB |
362.18 KB | 103.48% (🟢 -3.77%) |
/blobs |
79.05 KB |
412 KB | 117.71% (🟡 +13.21%) |
/block/[id] |
14.9 KB |
347.85 KB | 99.39% (🟢 -3.99%) |
/blocks |
76.75 KB |
409.7 KB | 117.06% (🟡 +13.19%) |
/tx/[hash] |
17.3 KB |
350.25 KB | 100.07% (🟡 +1.16%) |
/txs |
76.25 KB |
409.21 KB | 116.92% (🟡 +11.18%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #598 +/- ##
=======================================
Coverage 89.14% 89.14%
=======================================
Files 155 155
Lines 10492 10492
Branches 1187 1187
=======================================
Hits 9353 9353
Misses 1139 1139 ☔ View full report in Codecov by Sentry. |
- Hide y-axis byte units and display it on chart title - Fix displayed byte unit on y-axis
PJColombo
force-pushed
the
fix/web/chart-fixes
branch
from
e50b924
to
6b49fbe
Compare
apps/web/src/components/Charts/Transaction/DailyAvgMaxBlobGasFeeChart.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/components/Charts/Transaction/DailyAvgMaxBlobGasFeeChart.tsx
Outdated
Show resolved
Hide resolved
| @@ -2,6 +2,9 @@ const ETH_UNITS = { wei: 0, Gwei: 9, ether: 18 }; | |||
|
|
|||
| export type EthAmount = string | number | bigint; | |||
| export type EtherUnit = keyof typeof ETH_UNITS; | |||
| export type FormatOptions = Partial<{ | |||
There was a problem hiding this comment.
Now that we sometimes need formatWei and prettyFormatWei without a unit, I see why this option was added. However, I think a better approach would be to remove the unit display handling from these functions altogether and keep them focused purely on number formatting. Since we already pass the unit to these functions, we can append it directly where needed, like this:
`${formatWei(value, unit) ${unit}`
`${prettyFormatWei(value, unit) ${unit}`By keeping the function inputs minimal, we reduce the risk of a combinatorial explosion from too many options, which makes the function easier to test and maintain overall.
There was a problem hiding this comment.
The way I see it: formatting involves transforming a value into a more user-friendly and presentable format, which includes displaying the units.
If you just need to convert an amount, you can use convertWei.
To reduce test complexity, we can focus on testing each option separately and ensure the output is correct. For example: when testing the unit display option, we only need to verify that it works correctly, regardless of which unit is being targeted.
If no unit is provided, automatically determine and use the most appropriate unit
Checklist
Description
It adds the following fixes to the charts on the
/statspage:Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):
BEFORE
AFTER
