Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Suggest opening a new issue in Feedback form #602

Merged
merged 18 commits into from
Nov 8, 2024
Merged

Conversation

luis-herasme
Copy link
Member

Checklist

  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

Suggest opening a new issue in Feedback form

Related Issue (Optional)

Closes #512

Screenshots:

Before:
image
image
image

After:
image
image
image

Before:
image

After:
image

Copy link

changeset-bot bot commented Oct 21, 2024

🦋 Changeset detected

Latest commit: fb30835

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@blobscan/web Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blobscan-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 4:48pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
blobscan-docs ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 4:48pm
blobscan-gnosis ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 4:48pm
blobscan-holesky ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 4:48pm
blobscan-mainnet ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 4:48pm
blobscan-sepolia ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 4:48pm

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.14%. Comparing base (e7187c3) to head (fb30835).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #602      +/-   ##
==========================================
+ Coverage   89.02%   89.14%   +0.11%     
==========================================
  Files         154      155       +1     
  Lines       10259    10492     +233     
  Branches     1143     1187      +44     
==========================================
+ Hits         9133     9353     +220     
- Misses       1126     1139      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 21, 2024

📦 Next.js Bundle Analysis for @blobscan/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 332.16 KB (🔴 +86.54 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Pages Added

The following pages were added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/block_neighbor 251 B 332.41 KB 94.97%
/stats 348 KB 680.17 KB 194.33%

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/ 353.07 KB 685.23 KB 195.78% (🟢 -4.65%)
/address/[address] 28.54 KB 360.7 KB 103.06% (🟢 -4.34%)
/blob/[hash] 29.22 KB 361.39 KB 103.25% (🟢 -3.77%)
/blobs 79.05 KB 411.21 KB 117.49% (🟡 +13.20%)
/block/[id] 14.9 KB 347.06 KB 99.16% (🟢 -3.99%)
/blocks 76.75 KB 408.91 KB 116.83% (🟡 +13.20%)
/tx/[hash] 17.3 KB 349.46 KB 99.85% (🟡 +1.15%)
/txs 76.25 KB 408.42 KB 116.69% (🟡 +11.19%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link
Member

@PabloCastellano PabloCastellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked the old styles better

Copy link
Collaborator

@xFJA xFJA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Left a few comments! I have some topics to discuss:

  • Should we use a form here? We could wrap the component in a <form>
  • I think we could create a folder for FeedbackWidget and create FeedbackCard and Emoji in different files (similar to Dropdown implementation). This way we improve the readability of the component

apps/web/src/components/FeedbackWidget.tsx Outdated Show resolved Hide resolved
apps/web/src/components/FeedbackWidget.tsx Outdated Show resolved Hide resolved
apps/web/src/components/FeedbackWidget.tsx Outdated Show resolved Hide resolved
apps/web/src/components/FeedbackWidget.tsx Outdated Show resolved Hide resolved
apps/web/src/components/FeedbackWidget.tsx Outdated Show resolved Hide resolved
apps/web/src/components/FeedbackWidget.tsx Outdated Show resolved Hide resolved
apps/web/src/components/FeedbackWidget.tsx Outdated Show resolved Hide resolved
apps/web/src/components/FeedbackWidget.tsx Outdated Show resolved Hide resolved
Copy link
Member

@PJColombo PJColombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

I left some comments.

Also, can we optimise the svgs sizes by running pnpm svg:format from the root of the monorepo?

apps/web/src/components/FeedbackWidget/Emoji.tsx Outdated Show resolved Hide resolved
apps/web/src/components/FeedbackWidget/Emoji.tsx Outdated Show resolved Hide resolved
apps/web/src/components/FeedbackWidget/Emoji.tsx Outdated Show resolved Hide resolved
apps/web/src/pages/api/feedback/enabled.ts Outdated Show resolved Hide resolved
@PJColombo PJColombo self-requested a review November 8, 2024 16:43
@PJColombo PJColombo merged commit 5272928 into main Nov 8, 2024
14 checks passed
@PJColombo PJColombo deleted the add-open-issue branch November 8, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggest opening a new issue in Feedback form
4 participants