This repository has been archived by the owner on Dec 11, 2023. It is now read-only.
Handling of np.datetime64 and other scalar objects that have __getitem__ attribute in _eval_blocks() #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…em__ attribute - we first check if np.isscalar is true, then if __getitem__ attr is satisfied, and then all other conditions.
|
Your patch looks good to me. Could you please add a test unit for the new |
|
Added a test (test06) as part of the fetchwhereTest class and confirmed that it works as expected. Thanks! |
|
Removed some unused code in the test, now it should be all set - thanks! |
|
Excellent. Thank you! |
|
Thanks Francesc - any idea when this might be released to be pip installable for others on the team needing this? No rush, just wondering thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The __eval_blocks() function in chunked_eval.py mishandles np.datetime64 objects since they for some reason have the getitem attribute. This fix should allow users to use ctable.fetchwhere() functions off of datetime queries.