Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose sub_0207B0B0 to edit party menu hud #338

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kumakuma1
Copy link
Contributor

@kumakuma1 kumakuma1 commented Oct 22, 2024

  • Exposing sub_0207B0B0 that adds commands on the Pokemon in the Party Menu including the TM/HM field moves.

  • Added a config switch to use a custom check for the field moves, i.e. allowing for adding Fly, Flash etc on Pokemon without learning the move.

  • Badge check, Tile check, etc are still in place when using the fieldmove from the menu. However the moves/buttons work as if the Pokemon would know the move.

  • Of course you can also remove the config and custom check when merging
    image

  • adding sub_0207AFC4 and sub_0207E3A8 might allow the increase of max number of the buttons in the menu.
    https://github.com/pret/pokeheartgold/blob/9acc3cfc970d6fa8fef2a57e5e016b6a2bd62a09/src/party_menu.c#L1583

  • sub_0207AFC4 added, defined more member of the PartyMenu struct

@Aeliko Aeliko added enhancement New feature or request help wanted Extra attention is needed rom code Has to do with C code injected into ROM modernization Current/Later gen Functionality labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed modernization Current/Later gen Functionality rom code Has to do with C code injected into ROM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants