Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JOSS citation #208

Merged
merged 10 commits into from
Aug 20, 2024
Merged

Add JOSS citation #208

merged 10 commits into from
Aug 20, 2024

Conversation

ilkilic
Copy link
Contributor

@ilkilic ilkilic commented Aug 20, 2024

Also fix #207 and address #206 to keep the main Apache software license intact and provide separate licenses for the morph and mod files in the test and examples directories as mentioned in the updated Readme

@ilkilic ilkilic self-assigned this Aug 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.24%. Comparing base (fe4baed) to head (9682a88).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #208   +/-   ##
=======================================
  Coverage   91.24%   91.24%           
=======================================
  Files          95       95           
  Lines        5708     5708           
=======================================
  Hits         5208     5208           
  Misses        500      500           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@darshanmandge darshanmandge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
We should look into this issue later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #209 for this warning in the notebook:

NEURON: cADpyr_L2TPC_bluecellulab_0x7fde11797310 : a template cannot be redefined
near line 24

It should have created a new instance of the Cell in the loop. @anilbey can give us some idea to debug this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch @darshanmandge , I think using memory addresses for unique identifiers is not the best approach because Python can reuse memory addresses, leading to potential collisions and non-uniqueness. Instead, I would propose using UUIDs. I have tested it and it works. If that sounds good, I can create a new PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quickly looking into this! Sure, let's discuss this in a new PR.

@ilkilic ilkilic merged commit 5406434 into main Aug 20, 2024
9 checks passed
@ilkilic ilkilic deleted the citation-joss branch August 20, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

broken link in the examples README file
3 participants