-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JOSS citation #208
Add JOSS citation #208
Conversation
This reverts commit baebfcb.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
=======================================
Coverage 91.24% 91.24%
=======================================
Files 95 95
Lines 5708 5708
=======================================
Hits 5208 5208
Misses 500 500 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We should look into this issue later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch @darshanmandge , I think using memory addresses for unique identifiers is not the best approach because Python can reuse memory addresses, leading to potential collisions and non-uniqueness. Instead, I would propose using UUIDs. I have tested it and it works. If that sounds good, I can create a new PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for quickly looking into this! Sure, let's discuss this in a new PR.
Also fix #207 and address #206 to keep the main Apache software license intact and provide separate licenses for the morph and mod files in the test and examples directories as mentioned in the updated Readme