This repository has been archived by the owner on Mar 20, 2023. It is now read-only.
Avoid perl path from build machine appearing in wheel / binary distributions #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
It is expected that the GPU build with OpenMP (and NMODL) fails now that the tests use a non-default random seed. This is [probably] because there is a missing device update of |
olupton
force-pushed
the
pramodk/global-seed
branch
3 times, most recently
from
37f1e94
to
bded03f
Compare
alexsavulescu
approved these changes
Apr 14, 2022
…butions * In case of wheel, neuron wrapper scripts will set `CORENRN_PERLEXE` variable pointing to perl binary to use. Prefer that over `PERL_EXECUTABLE` found by CMake * Fixes #799
pramodk
force-pushed
the
pramodk/global-seed
branch
from
bded03f
to
160ecec
Compare
pramodk
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Apr 20, 2022
* Fix typo: CORENRN_PERLNEXE -> CORENRN_PERLEXE - See https://github.com/BlueBrain/CoreNeuron/blob/49bd200e34d6f66780483765ba985ce65534beda/extra/nrnivmodl_core_makefile.in#L84 * Update coreneuron for MacOS wheel fix - See BlueBrain/CoreNeuron/pull/800 * Update testcorenrn repository - See neuronsimulator/testcorenrn#11 - Setting different global seed in order to improve coverage
|
CI is failing with irrelevant gitlab errors. Upstream NEURON wheel is now working as expected. So will merge this. |
olupton
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Apr 21, 2022
* Fix typo: CORENRN_PERLNEXE -> CORENRN_PERLEXE - Should match nrnivmodl_core_makefile.in in CoreNEURON. * Bump CoreNEURON submodule past BlueBrain/CoreNeuron#800. * Bump testcorenrn "submodule" past testcorenrn#11. - Setting different global seed in order to improve coverage Co-authored-by: Olli Lupton <[email protected]>
pramodk
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
…butions (BlueBrain/CoreNeuron#800) In case of wheel, neuron wrapper scripts will set `CORENRN_PERLEXE` variable pointing to perl binary to use. Prefer that over `PERL_EXECUTABLE` found by CMake Fixes BlueBrain/CoreNeuron#799 CoreNEURON Repo SHA: BlueBrain/CoreNeuron@36a6277
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of wheel, neuron wrapper scripts will set
CORENRN_PERLEXEvariable pointing to perl binaryto use. Prefer that over
PERL_EXECUTABLEfound by CMakeFixes #799
CI_BRANCHES:NEURON_BRANCH=master,NMODL_BRANCH=master,SPACK_BRANCH=develop