This repository has been archived by the owner on Mar 20, 2023. It is now read-only.
Require C++17 #834
Merged
Require C++17 #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
alexsavulescu
approved these changes
Jul 5, 2022
This was referenced Jul 5, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Failures all came from the same GPU node (ldir01u13), but the GPU tests that passed also ran on the same node. One distinguishing feature between the GPU tests that passed and the ones that failed is that the passing ones do not have OpenMP host threading enabled. This may or may not be relevant, I can try and reproduce locally. Some backtraces from the core dumps in job 283903 (I only checked these 3, there are 7 more -- they'll be deleted in O(24hrs)):
|
olupton
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Jul 6, 2022
alexsavulescu
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Jul 6, 2022
* flex: require >= 2.6 to avoid register keyword. * flex/c++ standard documentation and fixes. * Use std:: prefix on cout, endl, istream, ostream etc. * drop gcc5 and gcc6, do not explicitly specify default cmake option values. * Use newer python patch versions and target macOS 10.14 instead of 10.9. * Dockerfile: newer flex * Dockerfile_gpu: base on `latest-x86_64` * C++17 in submodules. * Require C++17 in CoreNEURON too -> BlueBrain/CoreNeuron#834. * Require C++17 in InterViews too-> iv#43 & Bump to C++17 iv#44. * Require C++17 in NMODL too -> BlueBrain/nmodl#889 Co-authored-by: Alexandru Săvulescu <[email protected]>
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
* Bump submodule past nmodlBlueBrain/CoreNeuron#889. CoreNEURON Repo SHA: BlueBrain/CoreNeuron@511613e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump required C++ standard to C++17. Make some changes that were blocked by C++14.
TODO:
operator newthat should be usable with C++17: C++17: take advantage of overaligned operator new and aligned_alloc #836Use certain branches in CI pipelines.
CI_BRANCHES:NEURON_BRANCH=olupton/c++17,NMODL_BRANCH=master,SPACK_BRANCH=develop