rename feature names with ambiguity #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #98 +/- ##
==========================================
- Coverage 75.78% 75.73% -0.05%
==========================================
Files 51 51
Lines 4089 4089
==========================================
- Hits 3099 3097 -2
- Misses 990 992 +2
|
|
Apparently build.os needs to be specified for the recent version of readthedocs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"All" is a neurite name and the code sometimes creates ambiguous English feature names.
E.g. while
total axon areaandtotal dendrite volumeare fine,total all widthandtotal all areaare confusing.This PR changes the naming convention as follows.
From
"total {neurite_name} volume"to"total volume, {neurite_name}".That results in more understandable feature names e.g.
total volume, axontotal volume, all