Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process payment, balance endpoint #71

Merged
merged 14 commits into from
May 22, 2024
Merged

Process payment, balance endpoint #71

merged 14 commits into from
May 22, 2024

Conversation

bilalesi
Copy link
Collaborator

  1. allow setting default payment method at creation if no payment method already exists for a VLAB.
  2. add init processing payment endpoint (which will not save the budget, webhook will take care of that).
  3. add retrieve balance/amount_spent endpoint (spent money will be just a dummy data until integrating the accounting service).
  4. update docker compose to include stripe and fix network redirection to host machine. (after merge this PR, will delete the second docker compose, and related commands in Makefile).

@bilalesi bilalesi requested a review from Dinika May 21, 2024 09:54
Dinika
Dinika approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@Dinika Dinika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Just the pipeline is failing. Added some (nice to have) comments.

virtual_labs/tests/billing/test_init_payment_process.py Outdated Show resolved Hide resolved
virtual_labs/usecases/billing/init_vl_budget_topup.py Show resolved Hide resolved
virtual_labs/routes/billing.py Show resolved Hide resolved
@bilalesi bilalesi merged commit 7994b4a into main May 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dinika Dinika Dinika approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bilalesi @Dinika