Enhancement: PartitionGeometry #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joeykleingers
commented
Oct 5, 2022
•
joeykleingers
commented
- New partitioning mode that allows using an existing partitioning scheme.
- Feature attribute matrix created with the appropriate size.
- Edge case fix: if a user tries to partition a node geometry in Basic or Bounding Box mode where the geometry vertices or bounding box vertices are in a plane, the filter will error out correctly.
- A vertex mask option is now included (does nothing if the input geometry is cell-based)
- All new features are unit tested.
imikejackson
requested changes
Oct 5, 2022
Source/Plugins/Reconstruction/ReconstructionFilters/PartitionGeometry.h
Outdated
Show resolved
Hide resolved
|
Mike and I discussed this PR and he would like a vertex mask option added to this filter. |
Signed-off-by: Joey Kleingers <[email protected]>
Signed-off-by: Joey Kleingers <[email protected]>
Signed-off-by: Joey Kleingers <[email protected]>
Signed-off-by: Joey Kleingers <[email protected]>
Signed-off-by: Joey Kleingers <[email protected]>
Signed-off-by: Joey Kleingers <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Joey Kleingers <[email protected]>
joeykleingers
force-pushed
the
topic/PartitionGeometryEnhancements
branch
from
ef8666c
to
a61ddfc
Compare
jmarquisbq
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.