fix: handle devices listed before adapter in dbus managed objects #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
approved these changes
Oct 31, 2024
bdraco
reviewed
Oct 31, 2024
bdraco
reviewed
Oct 31, 2024
src/bluetooth_adapters/dbus.py
Outdated
| adapter = split_path[3] | ||
| if adapter not in adapters: | ||
| adapters[adapter] = unpacked_data | ||
| if not re.match(r"/org/bluez/hci\d+$", path_str): |
There was a problem hiding this comment.
Can you avoid using a regex here?
remove print
bdraco
changed the title
bdraco
reviewed
Oct 31, 2024
src/bluetooth_adapters/dbus.py
Outdated
Comment on lines
77
to
80
| try: | ||
| int(path_str[15:]) | ||
| except ValueError: | ||
| continue |
There was a problem hiding this comment.
Probably cleaner to path_str[15:].isdigit()
There was a problem hiding this comment.
isdigit() will accept leading zeros. Although this will accept a leading '-' character.
added 2 commits
October 31, 2024 01:30
|
GitHub seems to be stuck with a commit that I pushed. I'll try creating a new PR, sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the tests to show that this update handles the case when devices are listed before the adapter in the dbus managed_objects output.