-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix license classifier #10
Conversation
@@ -6,7 +6,6 @@ authors = [ | |||
{ name = "Aarni Koskela", email = "[email protected]" }, | |||
] | |||
requires-python = ">=3.9" | |||
license = "MIT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this removed, though? I'm pretty sure there are plenty of tools that read this field rather than classifiers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the classifier sets it on the license field in pypi iirc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, apparently it does the thing alright:
(ruuvitag-ble) ~/b/ruuvitag-ble (main) $ python
>>> import importlib.metadata as im
>>> im.metadata("ruuvitag-ble")
>>> m["License-Expression"]
'MIT'
>>>
Never mind! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should probably be reverted.Hatchling
prefers the license
field of classifier. PyPI will add support for License-Expression
soon as well.
https://hatch.pypa.io/1.11/config/metadata/#spdx-expression
pypi/warehouse#16620
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #25
Hey 👋🏻,
I am currently looking into licensing at Home Assistant, and I found that we could not detect the license of this library properly. According to pyproject.toml documentation about the
license
field:If you could do a release after this PR, and maybe bump in Home Assistant, that would be awesome :)