Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy to lambda using serveless framework. #96

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

demeringo
Copy link
Collaborator

@demeringo demeringo commented Jun 6, 2022

First attempt to implement #95
Packaging and deployment with serverlesss framework works, and API is served from AWS lambda.

There remain a problem with the links in openapi doc that do not include the default stage prefix used when deploying with the serverless framework.

For example:
OpenAPI is pointing to this URL (without the dev prefix):

https://1rq5nf92sb.execute-api.eu-west-1.amazonaws.com/v1/server/all_default_models

while content is served from the same URL (but with the dev prefix):

https://1rq5nf92sb.execute-api.eu-west-1.amazonaws.com/**dev**/v1/server/all_default_models

Note: this issue would disappear if using a custom domain (like dev.boa.my-domain.com and prod/boa.my-domain.com).

Works only partially: openapi doc links are missing the stage prefix.
@demeringo
Copy link
Collaborator Author

demeringo commented Jun 10, 2022

I think that we should merge it
Ratiaonale is that it can already provide the funtionnality (event if the OpenAPI spec does do fully work yet in serverless mode, which can be addressed later). I registered an issue for this #99.

But would appreciate a quick test from someone else to be sure that this PR has no side effect on the standard API (not serverless).

@demeringo demeringo marked this pull request as ready for review June 10, 2022 07:40
@demeringo demeringo changed the title WIP: deploy to lambda using serveless framework. Deploy to lambda using serveless framework. Jun 12, 2022
@da-ekchajzer
Copy link
Collaborator

Thank you very much for the PR. I have tested it under the usual conditions works like it should.
I am merging it !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants