Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix build with pipewire-jack #99

Merged
merged 1 commit into from
Feb 12, 2022
Merged

fix build with pipewire-jack #99

merged 1 commit into from
Feb 12, 2022

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Jan 28, 2022

@Be-ing Be-ing mentioned this pull request Jan 28, 2022
Open
@Boddlnagg
Copy link
Owner

Thank you! The update of the jack-sys version included in #98 should make this PR unnecessary, but I'll leave it open until that PR is merged.

@Boddlnagg Boddlnagg mentioned this pull request Jan 28, 2022
Open
@Boddlnagg
Copy link
Owner

If you say that jack-sys version 0.2.3 is required, would #98 be sufficient? It upgrades to version ~0.2.1, but that would be semver-compatible with version 0.2.3, if I'm not mistaken. So you could get midir to use 0.2.3 by requiring 0.2.3 in your downstream crate.

I will still leave this issue open until the required version of jack-sys is 0.2.3 or later.

@Be-ing
Copy link
Contributor Author

Be-ing commented Jan 29, 2022

How about simply using jack-sys = "0.2" without specifying the patch version?

@Boddlnagg
Copy link
Owner

Yep, that's a good idea :-)

@Boddlnagg Boddlnagg merged commit dc4047d into Boddlnagg:master Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Be-ing @Boddlnagg