Issue 52 - add aria-hidden to taglines not shown #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good ty |
avonville
approved these changes
Apr 3, 2023
Merged
jamesros161
added a commit
that referenced
this pull request
Apr 5, 2023
* update info dropdown for footer link colors (#55) * add aria-hidden to taglines not shown (#58) * add notice to logo panel (#59) * Issue 50 - Improve Color Palettes by using color variables instead of SCSS compilation during runtime (#54) * remove runtime compiling of SCSS color palettes * add variable generation to customizer js * append updated colors to head * add css variables to saved palette theme_mod * fix alternative parsing of palette values * footer link color to work like other link controls * add footer link selectors * change footer link color control to new name * set color pallette to postMessage * ensure updated color palette values are available * fix footer color updates * update versions for alpha * update side branch with master changes (#51) * Create pull_request_template.md * Branch 2.19.1 (#47) * set rc release version * Separate top & bottom blog page post margins * Revert "Separate top & bottom blog page post margins" This reverts commit 55585fd. * Salon theme styles (#42) * add salon theme styles * update styles to fix MFW rows * Fix Blog Category links not working - Issue 37 (#43) * fix cats not showing if uncategorized * fix category 404s * Separate Blog Post List Post Margin controls - Issue 38 (#41) * Split blog page post margins into two controls * change title of lower margin control * Fix Submenu Padding for first menu item - Issue 39 (#40) * issue-786 version set * fix left padding of first-item submenus * update version for test-zip * revert version to rc1 * add filters (#45) * re-add letter-spacing (#19) * update readme * revert letter-spacing changes * remove RC1 from version tag * update versions and readme * fix translucency issues * fix SINCEVERSION * fix incorrect '-raw' value in css * add comments * add comments * remove commented out code * add fallback for bgtfw_footer_links * fix footer links. again. * phpcs fixes * fix raised buttons and overlays * set versions to rc1 * fixed issues due to merge conflicts * fix repeated changes not binding * Rc1 fixes (#62) * add colorx-background-alpha styles * fix menu items font color not updating right * update versions for stable * update readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE: Resolves #52
PROJECT: Crio 2.20.0
add aria-hidden to taglines not shown
Test Files
crio-2.20.0-issue-52.zip
NOTES TO TESTER
Please leave comments regarding issues found in testing directly on the issue linked above, not the Pull Request. This helps ease the process of reviewing the testing of multiple PRs in a given project from the project view.
Please remember to move this item from 'Needs Review' to either 'In Progress' or 'Awaiting Release' depending on the results of your testing
Testing Instructions