Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I added a new "Flowerfield" theme for LibreMines #41

Merged
merged 11 commits into from
Feb 17, 2022

Conversation

SecularSteve
Copy link
Contributor

flowerfield

It's supposed to be based on the "Flower Garden" theme from the Windows Vista/7 Minesweeper iteration.
A more "Child-friendly" variant, I guess you could say.

I especially loved those ambient sounds every time you stepped on a flower.

In case I missed a spot, feel free to point it out. I'm not some super-powered genius.
In case you think that there could be some changes made, feel free to let me know.

Made in Inkscape, the Numbers use the "Lily" font, it's under the CC BY-SA 4.0

Based on Flower Garden in the Vista/7 Minesweeper iteration...
Based on the Vista/7 "Flower Garden" Minesweeper theme.
@SecularSteve
Copy link
Contributor Author

P.S.
There's two things that need to be corrected.

  1. The folder within a folder.
  2. The placeholder needs to be removed.

@Bollos00
Copy link
Owner

Hi there. Sorry for the delay and thanks to your interest in contributing to libremines.

As you said, the 'folder within a folder' change. The theme folder should be as explained here. The new theme can be installed as a cmake option like alternative_dark and alternative_light themes.

I tested it here, but unfortunately it does not seen to work as expected here... See the screenshot.

Screenshot_20220214_025212

The five files bellow open correctly on inkscape, but not by the qt engine. I believe that this is an issue with the qt framework and I may search for a workaround for it.

  • boom.svg
  • flag.svg
  • mine.svg
  • no_flag.svg
  • wrong_flag.svg

The font size of the numbers appear a little big for me, but it is weird that I do not see those at all on the minefield...

Screenshot_20220214_030503

@SecularSteve
Copy link
Contributor Author

SecularSteve commented Feb 14, 2022

I see...

As for the last part, it must be another one of those "Object to Path" issues in Inkscape when it comes to font type and size.

It only happens if you don't have the font that goes with the text on your device, so it chooses the default.

I'll send over the "flattened" 0-8 numbers today if I can.

@Bollos00
Copy link
Owner

Screenshot_20220214_033531

I managed to make the qt engine load the svg files properly by "picking the color" and then "filling on the right places". It is silly but solves the issue. I do not know it there is a better solution tho...

flowerfield.zip

Here are some of the files

@Bollos00
Copy link
Owner

I'll send over the "flattened" 0-8 numbers today if I can.

There is no hurry. You can do it when you get time ;)

it's just that
…n of the theme in the correct place.

As it says here...
Based on Flower Garden in the Vista/7 Minesweeper iteration.
This time, it's in the correct place, and I fixed some font issues.
It's already in the description, so there's no need for it.
@SecularSteve
Copy link
Contributor Author

I'm finished (I think)...
Make sure just in case, and use all of the numbers this time. It will look so much better.

@Bollos00
Copy link
Owner

Screenshot_20220215_115036

The numbers are displayed correctly now. I will just do the workaround for the qt.svg to properly loads the image.

@Bollos00
Copy link
Owner

See here. The only thing needs to be done is to add the piece of code bellow.

        install(
            DIRECTORY share/minefield_themes/flowerfield
            DESTINATION share/libremines/minefield_extra_themes
            )

@Bollos00
Copy link
Owner

It is nice, @SecularSteve. Congratulations!

Screenshot_20220216_220822
Screenshot_20220216_220654

@Bollos00
Copy link
Owner

flowerfield.zip

Here it is the svg files with the workaround that I mentioned.

@SecularSteve
Copy link
Contributor Author

Should I add that last piece of code mentioned above, or?

@Bollos00
Copy link
Owner

Great. Now after you undo the changes made on share/minefield_themes.qrc and replace the current svg files of flowerfield theme with the ones that I uploaded in this comment, I can close the finish this pull request

Apparently, it's unnecessary...
Fixed with the following replacements...
Based on Flower Garden in the Vista/7 Minesweeper iteration...
This time with a colouring fix.
@SecularSteve
Copy link
Contributor Author

I think I'm done.
Check if you can just in case.

@Bollos00 Bollos00 merged commit 89311c9 into Bollos00:master Feb 17, 2022
@Bollos00
Copy link
Owner

Merged. Thank you for your contribution 🤝

@SecularSteve SecularSteve deleted the SecularSteve-flowerfield_theme branch February 17, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants