-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I added a new "Flowerfield" theme for LibreMines #41
I added a new "Flowerfield" theme for LibreMines #41
Conversation
that's all...
Based on Flower Garden in the Vista/7 Minesweeper iteration...
Based on the Vista/7 "Flower Garden" Minesweeper theme.
P.S.
|
Hi there. Sorry for the delay and thanks to your interest in contributing to libremines. As you said, the 'folder within a folder' change. The theme folder should be as explained here. The new theme can be installed as a cmake option like I tested it here, but unfortunately it does not seen to work as expected here... See the screenshot. The five files bellow open correctly on inkscape, but not by the qt engine. I believe that this is an issue with the qt framework and I may search for a workaround for it.
The font size of the numbers appear a little big for me, but it is weird that I do not see those at all on the minefield... |
I see... As for the last part, it must be another one of those "Object to Path" issues in Inkscape when it comes to font type and size. It only happens if you don't have the font that goes with the text on your device, so it chooses the default. I'll send over the "flattened" 0-8 numbers today if I can. |
I managed to make the qt engine load the svg files properly by "picking the color" and then "filling on the right places". It is silly but solves the issue. I do not know it there is a better solution tho... Here are some of the files |
There is no hurry. You can do it when you get time ;) |
it's just that
…n of the theme in the correct place. As it says here...
Based on Flower Garden in the Vista/7 Minesweeper iteration. This time, it's in the correct place, and I fixed some font issues.
It's already in the description, so there's no need for it.
I'm finished (I think)... |
See here. The only thing needs to be done is to add the piece of code bellow.
|
It is nice, @SecularSteve. Congratulations! |
Here it is the svg files with the workaround that I mentioned. |
Should I add that last piece of code mentioned above, or? |
the last step hopefully...
Great. Now after you undo the changes made on share/minefield_themes.qrc and replace the current svg files of flowerfield theme with the ones that I uploaded in this comment, I can close the finish this pull request |
Apparently, it's unnecessary...
Fixed with the following replacements...
Based on Flower Garden in the Vista/7 Minesweeper iteration... This time with a colouring fix.
I think I'm done. |
Merged. Thank you for your contribution 🤝 |
It's supposed to be based on the "Flower Garden" theme from the Windows Vista/7 Minesweeper iteration.
A more "Child-friendly" variant, I guess you could say.
I especially loved those ambient sounds every time you stepped on a flower.
In case I missed a spot, feel free to point it out. I'm not some super-powered genius.
In case you think that there could be some changes made, feel free to let me know.
Made in Inkscape, the Numbers use the "Lily" font, it's under the CC BY-SA 4.0