Cleanup and fix build

[davidkarlsen]

1. vendor dir should not be present? Won't it be fetched with godep?
2. There is both an ADD and also a build via go get of the source repo

[davidkarlsen]

I see dockerhub is struggling a bit for the moment, but this builds fine locally:

docker build .
Sending build context to Docker daemon   3.55MB
Step 1/8 : FROM golang:1.11 as golang
 ---> 343df9d12b7b
Step 2/8 : ARG GODEP_VERSION=v0.5.0
 ---> Running in a6b54078ca17
Removing intermediate container a6b54078ca17
 ---> 9aec60fc624c
Step 3/8 : RUN curl -fsSL -o /usr/local/bin/dep https://github.com/golang/dep/releases/download/${GODEP_VERSION}/dep-linux-amd64 &&         chmod +x /usr/local/bin/dep &&         go get -u github.com/BonnierNews/logstash_exporter &&         cd $GOPATH/src/github.com/BonnierNews/logstash_exporter &&         dep ensure &&         make
 ---> Running in 6cdfb9b68255
>> Cleaning up
>> formatting code
>> linting code
WARNING: Linters are now vendored by default, --update ignored. The original
behaviour can be re-enabled with --no-vendored-linters.

To request an update for a vendored linter file an issue at:
https://github.com/alecthomas/gometalinter/issues/new

>> building binaries
 >   logstash_exporter
>> running tests
?       github.com/BonnierNews/logstash_exporter        [no test files]
ok      github.com/BonnierNews/logstash_exporter/collector      0.013s
Removing intermediate container 6cdfb9b68255
 ---> 3daee41bf656
Step 4/8 : FROM busybox:1.30.0-glibc
 ---> 755a27036678
Step 5/8 : COPY --from=golang /go/src/github.com/BonnierNews/logstash_exporter/logstash_exporter /
 ---> cbc21ab489f6
Step 6/8 : LABEL maintainer [email protected]
 ---> Running in b742ef22c418
Removing intermediate container b742ef22c418
 ---> bbaa17366051
Step 7/8 : EXPOSE 9198
 ---> Running in d87f37b89d88
Removing intermediate container d87f37b89d88
 ---> 27faac74138a
Step 8/8 : ENTRYPOINT ["/logstash_exporter"]
 ---> Running in e3b0c3ae6166
Removing intermediate container e3b0c3ae6166
 ---> 5ce21590505e
Successfully built 5ce21590505e
Davids-Work-MacBook-Pro:logstash_exporter et2448$ 

[davidkarlsen]

@christoe PTAL? This one + #32 and #33

[mpucholblasco]

I guess this repo is dead, is somebody else taking the responsibility? I'm just taking the most important PRs and merging into my own (present on https://github.com/mpucholblasco/logstash_exporter) to fix some issues.

@davidkarlsen , as you have more PRs, do you want to take care of it? If this is the case, I can do PRs to your branch.

@christoe , please, could you confirm us if this repo is going to take PRs or improvements?

[davidkarlsen]

@mpucholblasco Not really a go-wiz - just fixed some of the build-stuff...

[davidkarlsen]

@christoe back from vacation?

[davidkarlsen]

?

[karl-tpio]

Just wanted to say thank you to @davidkarlsen and @mpucholblasco for your work on keeping the repo semi up to date.

It does seem that @mpucholblasco has a more "functional" repo, currently. I will try to get the Dockerfile updated to use this repo for the build process and get a PR in to @mpucholblasco once working.

[mpucholblasco]

Sure about PR about Dockerfile, @karl-tpio . In fact, I had it in mind, thanks!

However, if you want to keep the repo, go ahead and I will do PRs to it in the future... What you prefer.