Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No Case: Added more logs for debugging sampling. #67

Open
wants to merge 1 commit into
base: releases/0.8.6
Choose a base branch
from
Open

No Case: Added more logs for debugging sampling. #67

wants to merge 1 commit into from

Conversation

RuofanKong
Copy link
Collaborator

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Edilmo
Edilmo approved these changes Apr 7, 2021
View reviewed changes
Copy link

@Edilmo Edilmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I think those changes are not going to make their way to public. Those logs are going to be noisy

Random-Word
Random-Word approved these changes Apr 7, 2021
View reviewed changes
Copy link

@Random-Word Random-Word left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay more logs!

@RuofanKong
Copy link
Collaborator Author

LGTM but I think those changes are not going to make their way to public. Those logs are going to be noisy

@Edilmo Is there a case in your mind that the log would be noisy? I'm curious about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Edilmo Edilmo Edilmo approved these changes

@Random-Word Random-Word Random-Word approved these changes

@bimalkmehta bimalkmehta Awaiting requested review from bimalkmehta

@AdityaGudimella AdityaGudimella Awaiting requested review from AdityaGudimella

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RuofanKong @Random-Word @Edilmo