Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tsc): remove flag verbatimModuleSyntax from pre-push hook #320

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

fernandomg
Copy link
Member

Description:

Removes the flag verbatimModuleSyntax passed to the tsc command on the pre-push hook.

This brought more issues than solutions, and we have the' types' import covered from the ESLINT rules included by @gabitoesmiapodo in the PR #310.

Steps:

Be sure that a push triggers the pre-push hook

Type of change:

  • New feature
  • Bug fix
  • Breaking change
  • Enhancement
  • Refactoring
  • Chore

How Has This Been Tested?

  • Manual testing
  • Automated tests
  • Other (explain)

Remember to check that:

  • Your code follows the style guidelines of this project
  • You have performed a self-review of your code
  • You have commented your code in hard-to-understand areas
  • You have made corresponding changes to the documentation
  • Your changes generate no new warnings

Screenshots

(Add screenshots or videos to help test this pull request)

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dappbooster ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 6:31pm
docs.dappbooster ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 6:31pm

@fernandomg
Copy link
Member Author

fernandomg commented Sep 24, 2024

@gabitoesmiapodo 👀

@gabitoesmiapodo gabitoesmiapodo merged commit 7f77a5b into develop Sep 24, 2024
6 checks passed
@gabitoesmiapodo gabitoesmiapodo deleted the chore/stop-using-verbatimMdouleSyntax branch September 24, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants