Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog prompts failing tests on 4.3.4 and 4.4 #57

Closed
szul opened this issue Jul 4, 2019 · 5 comments
Closed

Dialog prompts failing tests on 4.3.4 and 4.4 #57

szul opened this issue Jul 4, 2019 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed question Further information is requested test Related to unit testing and automated test scripts

Comments

@szul
Copy link
Contributor

szul commented Jul 4, 2019

For the botbuilder-dialogs-prompts, running the tests throws the following error per dialog prompt:

Error: DialogSet.add(): Invalid dialog being added.
      at DialogSet.add (test\node_modules\botbuilder-dialogs\lib\dialogSet.js:190:19)
      at Context.it (test\index.test.js:33:17)

The code for these dialog prompts parallels the dialog prompts in the Microsoft repo. Not sure what the failure is coming from. Needs further investigation.

@szul szul added bug Something isn't working help wanted Extra attention is needed question Further information is requested test Related to unit testing and automated test scripts labels Jul 4, 2019
@szul
Copy link
Contributor Author

szul commented Jul 4, 2019

@benbrown Any insight here would be appreciated.

@benbrown
Copy link
Contributor

benbrown commented Jul 4, 2019

This might be a package version thing - all of the BOTBUILDER packages should be the same version

@szul
Copy link
Contributor Author

szul commented Jul 5, 2019

Resolved by #58.

@benbrown Would believe there was an errant node_modules folder in the test directory that was the conflict. Not even sure how that got there on my local machine. UGH.

@szul szul closed this as completed Jul 5, 2019
szul added a commit that referenced this issue Mar 16, 2020
@brunohjs
Copy link

This might be a package version thing - all of the BOTBUILDER packages should be the same version

Nice!!!
I had the same problem.
My botbuilder-testing package was at version 4.9.0, while botbuilder was at version 4.8.0.
I changed the version of botbuilder-testing to 4.8.0 and it worked!
Thanks!!!

@Noman-121
Copy link

image

can anyone help me i am facing this issue while trying to install coreui-react-pro on ms teams personal tab here is version issue but i have try to install some versions of coreui-react-pro version but not working
package.json file

"react": "^16.14.0",
"react-dom": "^16.14.0",
"@coreui/react-pro": "^4.7.0",

   error
   ------------------------------------------

npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR! react@"^16.14.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@">=17" from @coreui/[email protected]
npm ERR! node_modules/@coreui/react-pro
npm ERR! @coreui/react-pro@"^4.7.0" from the root project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed question Further information is requested test Related to unit testing and automated test scripts
Projects
None yet
Development

No branches or pull requests

4 participants