Contributor update #2652
Contributor update #2652
Conversation
previously this would only diagnose apps that exit with an exit code of 1
| yad "${yadflags[@]}" --class Pi-Apps --name "Pi-Apps" --width=700 --height=300 --title="Pi-Apps install/uninstall/updates complete" \ | ||
| --image="${DIRECTORY}/icons/logo-64.png" --image-on-top \ | ||
| --text='Thanks for using Pi-Apps!'$'\n'"The following apps were succcessful: $successful_apps" \ | ||
| --wrap --fontname=12 \ | ||
| --button='Ok' |
There was a problem hiding this comment.
This is the dialog I was suggesting that we have present the "thanks for using pi-apps" text with a call to action and the icons of the apps that were successfully installed/uninstalled/updated.
I think we had some code that presented all the app icons on one screen in the history of pi-apps somewhere. It would be interesting to do that but also show a small icon in the top left of each app icon for installing/uninstalling/updating.
There was a problem hiding this comment.
I think we had some code that presented all the app icons on one screen in the history of pi-apps somewhere.
Yeah this:
And I removed it as part of this because we were using the splashscreen to hide the fact that (at the time) pi-apps was slow to start:
So we can bring that splashscreen code back (with modifications) for use in finish dialog.
There was a problem hiding this comment.
So we can bring that splashscreen code back (with modifications) for use in finish dialog.
I brought it back b54a26d so we can more easily discuss how we would like to adjust it for use as described in the first comment in this thread.
| @@ -420,6 +420,7 @@ $app" | |||
| [ -z "$geometry2" ] && geometry2='--center' | |||
|
|
|||
| tail -f --retry "${DIRECTORY}/data/manage-daemon/yadlist" 2>/dev/null | yad --class Pi-Apps --name "Pi-Apps" --width=330 --height=400 "$geometry2" --title='Monitor Progress' \ | |||
| --text="We are always looking for fresh ideas and new contributors to join our team: <a href="\""https://pi-apps.io/#get-involved"\"">https://pi-apps.io/#get-involved</a>" \ | |||
There was a problem hiding this comment.
For this I want to make a dedicated webpage for "new contributors" to link to that goes over the things we discussed in the discord, attempting to welcome users into the "family" of pi-apps contributors.
Co-Authored-By: Botspot <[email protected]>
@Botspot this is by no means final. I have created this PR so we can start to discuss the exact wording and the presentation of the information that we discussed in #dev-chat on the discord. The wording can (and likely should) fully change and was kept brief so as to not waste my time on something that we didn't agree on.