Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make render messages dynamic and use hoisted_class_prefix instead of "schema" #1155

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

antoniosarosi
Copy link
Contributor

@antoniosarosi antoniosarosi commented Nov 11, 2024

Important

Add hoisted_class_prefix to RenderOptions for customizable hoisted class prefixes in rendered messages.

  • Behavior:
    • RenderOptions in types.rs now supports hoisted_class_prefix to customize prefix for hoisted classes.
    • Default prefix for hoisted classes changed from "schema" to user-defined or "interface".
    • Updated rendering logic in OutputFormatContent to use hoisted_class_prefix.
  • Documentation:
    • Added hoisted_class_prefix parameter to output-format.mdx with examples.
  • Tests:
    • Added tests in types.rs to verify hoisted_class_prefix functionality.

This description was created by Ellipsis for 6c7c38c. It will automatically update as commits are pushed.

Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
baml ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 5:39pm

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 6c7c38c in 56 seconds

More details
  • Looked at 173 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. fern/03-reference/baml/prompt-syntax/output-format.mdx:164
  • Draft comment:
    The example should reflect the dynamic prefix change. Update the example to use the hoisted_class_prefix value instead of the hardcoded "schema".
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
2. fern/03-reference/baml/prompt-syntax/output-format.mdx:179
  • Draft comment:
    The example should reflect the dynamic prefix change. Update the example to use the hoisted_class_prefix value instead of the hardcoded "schema".
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_fVS56CMa45auVv47


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@antoniosarosi antoniosarosi added this pull request to the merge queue Nov 11, 2024
Merged via the queue into canary with commit 873751b Nov 11, 2024
9 of 10 checks passed
@antoniosarosi antoniosarosi deleted the antonio/render-messages branch November 11, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant