Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflow): 🐛 fixed issue with lerna version bump #869

Merged
merged 2 commits into from
Jul 28, 2024
Merged

Conversation

WasiqB
Copy link
Member

@WasiqB WasiqB commented Jul 28, 2024

Closes: #867

Type of changes?

  • Bug fixes: Non-breaking change which fixes an issue
  • New feature: Non-breaking change which adds a new feature
  • Performance improvement: Non-breaking change which improves performance
  • Documentation: Non-breaking change which improves documentation
  • Other: Non-breaking change which does not fit into the above categories
  • Breaking change: A breaking change which requires a new version of the library

Checklist for Java project

  • Change not related to Java project

Following checklists are optional if above checkbox is selected:

  • Copyright banner comment added to newly added files, except *.md, *.yml, *.json?
  • Proper JavaDoc updated in main and test classes for all public classes and methods?
  • Tests added for changes?
  • Tests are passing locally?
  • Check style checks are passing locally?
  • Test coverage is at least 80% for newly added changes?
  • There are no SonarCloud issues?
  • README updated? (if applicable)
  • Documentation website updated for the PR raised?

Checklist for Website

  • Change not related to Website project

Following is optional if above checkbox is selected:

  • Lint check passes locally?
  • Prettier check passes locally?
  • Build command working fine locally?

Reviewers

@BoykaFramework/boyka-core

IMPORTANT: Make sure to check the Allow edits from maintainers box below this window

@WasiqB WasiqB self-assigned this Jul 28, 2024
@github-actions github-actions bot added the 🐛 pr: bug fix PR which fixes a bug label Jul 28, 2024
Copy link

sonarcloud bot commented Jul 28, 2024

@WasiqB WasiqB marked this pull request as ready for review July 28, 2024 14:36
@WasiqB WasiqB requested a review from a team as a code owner July 28, 2024 14:36
@WasiqB WasiqB merged commit 42e51ce into main Jul 28, 2024
21 checks passed
@WasiqB WasiqB deleted the issue-867 branch July 28, 2024 14:48
WasiqB added a commit that referenced this pull request Jul 28, 2024
@WasiqB WasiqB restored the issue-867 branch July 28, 2024 14:55
@WasiqB
Copy link
Member Author

WasiqB commented Jul 29, 2024

🚀 This pull request is included in v2.0.0. See Release 2.0.0 for release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 pr: bug fix PR which fixes a bug
Projects
Development

Successfully merging this pull request may close these issues.

🐛 New Bug: Lerna version does not bump to the required version
1 participant