Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup api for TrainStream, CrossValidate, and Typescript #275

Merged
merged 1 commit into from
Sep 20, 2018
Merged

Cleanup api for TrainStream, CrossValidate, and Typescript #275

merged 1 commit into from
Sep 20, 2018

Conversation

robertleeplummerjr
Copy link
Contributor

@robertleeplummerjr robertleeplummerjr commented Sep 20, 2018 •
edited
Loading

A GIF or MEME to give some spice of the internet

Description

These are some fairly important parts of machine learning that already mostly existed in brain.js and needed to be fixed for modern node. This achieves that.

Motivation and Context

There are a few issues open for TrainStream & CrossValidate, I will try and list all of them here:
#274
#226
#144
#185

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue) (these were existing features)
  • New feature (non-breaking change which adds functionality) (these existing features were slightly changed)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Author's Checklist:

  • My code focuses on the main motivation and avoids scope creep.
  • My code passes current tests and adds new tests where possible.
  • My code is SOLID and DRY.
  • I have updated the documentation as needed.

Reviewer's Checklist:

  • I kept my comments to the author positive, specific, and productive.
  • I tested the code and didn't find any new problems.
  • I think the motivation is good for the project.
  • I think the code works to satisfies the motivation.

@robertleeplummerjr
fix: TrainStream, CrossValidate, and Typescript
eebe6c8 
Overhauled the internals of TrainStream and CrossValidate so they are decoupled from the networks themselves, as well as being able to restore or store CrossValidate from json.

Added examples for CrossValidate and TrainStream, and as well one for learning math, to test the typescript type file.

Too I added missing typescript configs and examples.

*
@robertleeplummerjr robertleeplummerjr changed the base branch from master to v1.x September 20, 2018 17:09
@robertleeplummerjr robertleeplummerjr self-assigned this Sep 20, 2018
@robertleeplummerjr robertleeplummerjr merged commit b2bec1e into v1.x Sep 20, 2018
@robertleeplummerjr robertleeplummerjr deleted the cleanup-api branch September 20, 2018 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mubaidr mubaidr mubaidr approved these changes

Assignees

@robertleeplummerjr robertleeplummerjr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertleeplummerjr @mubaidr