Fix options is undefined! #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/cross-validate.js
Outdated
| @@ -116,7 +116,7 @@ export default class CrossValidate { | |||
| let dclone = data.slice(0); | |||
| let testSet = dclone.splice(i * size, size); | |||
| let trainSet = dclone; | |||
| let result = this.testPartition(options, trainOpts, trainSet, testSet); | |||
| let result = this.testPartition(this.options, trainOpts, trainSet, testSet); | |||
There was a problem hiding this comment.
Nice find! We could (should) simplify this. We don't need to pass options to testPartition because it is part of this, can you remove here and reference there?
There was a problem hiding this comment.
I take it back, this.options just needs removed in this case. I'll go ahead and commandeer this as I need it for work this morning.
robertleeplummerjr
approved these changes
Sep 27, 2018
|
Ty sir! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#185 (comment)