Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix CrossValidate to have tests for when data too small #281

Merged
merged 1 commit into from
Oct 2, 2018

Conversation

robertleeplummerjr
Copy link
Contributor

Also upgrade to use newer es6 syntax for defining optional properties.
Upgrade examples to be more straightforward when using CrossValidate.
Fix values from being set to NaN when training with smaller data in CrossValidate.

A GIF or MEME to give some spice of the internet

Description

Fixes #185.

Motivation and Context

issue

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Author's Checklist:

  • My code focuses on the main motivation and avoids scope creep.
  • My code passes current tests and adds new tests where possible.
  • My code is SOLID and DRY.
  • I have updated the documentation as needed.

Reviewer's Checklist:

  • I kept my comments to the author positive, specific, and productive.
  • I tested the code and didn't find any new problems.
  • I think the motivation is good for the project.
  • I think the code works to satisfies the motivation.

Also upgrade to use newer es6 syntax for defining optional properties.
Upgrade examples to be more straightforward when using CrossValidate.
Fix values from being set to NaN when training with smaller data in CrossValidate.
@mubaidr
Copy link
Contributor

mubaidr commented Oct 2, 2018

Should be merged! Anything missing?

@robertleeplummerjr robertleeplummerjr merged commit fc48ae6 into v1.x Oct 2, 2018
@robertleeplummerjr robertleeplummerjr deleted the 185-cross-validation-fixes branch October 2, 2018 14:16
@robertleeplummerjr
Copy link
Contributor Author

nope, just busy busy. Ty!

@mubaidr mubaidr mentioned this pull request Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants