Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add ability to pass CLI params to hemtt executable for launch presets #735

Closed
DartRuffian opened this issue Aug 7, 2024 · 4 comments · Fixed by #752
Closed
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@DartRuffian
Copy link
Contributor

Allow launch presets to specify hemtt params.

A basic use-case is adding a preset to binarize files and disable filepatching for testing animations quickly. Doing hemtt launch -b --no-filepatching is fine, but might be a bit annoying to remember the syntax (i.e. "Is it -no-filepatching or -no-file-patching" or something)

Example:

[hemtt.launch.animations]
hemtt_parameters = [
    "-b",
    "--no-filepatching",
]
@BrettMayson BrettMayson added enhancement New feature or request good first issue Good for newcomers labels Aug 7, 2024
@BrettMayson
Copy link
Owner

BrettMayson commented Aug 7, 2024

I think just cli or options would be good, shouldn't be too confusing with context

Also, should this just allow the full names?

args = [
  "--binarize",
  "--quick",
]

rather than allowing

args = [
  "-b",
  "-Q",
]

@DartRuffian
Copy link
Contributor Author

Theoretically it would just be passed to the executable directly, why make it so you can't use the shorthand?
Most people would probably still use the full parameter anyway for readability, but seems like extra logic that doesn't really need to be there

@BrettMayson
Copy link
Owner

It would not be passed to the executable, we're already running

@DartRuffian
Copy link
Contributor Author

Yeah that makes sense, clearly wrote it too early in the morning. Yeah probably only allow fully spelled out parameters for readability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants